fix: dynamic json parsing of process output #186

rnbguy · 2022-11-10T21:46:32Z

Closes #184

atomkraft/chain/node.py

rnbguy added the bug Something isn't working label Nov 10, 2022

rnbguy requested a review from ivan-gavran November 10, 2022 21:46

rnbguy self-assigned this Nov 10, 2022

rnbguy changed the title ~~fix: parse binary output dynamically~~ fix: dynamic json parsing of process output Nov 11, 2022

rnbguy marked this pull request as ready for review November 11, 2022 12:46

rnbguy requested a review from hvanz November 11, 2022 12:47

rnbguy force-pushed the rano/dyn-parse-stdout-stderr branch from 16215fe to 8071ebc Compare November 11, 2022 15:55

hvanz approved these changes Nov 17, 2022

View reviewed changes

atomkraft/chain/node.py Outdated Show resolved Hide resolved

rnbguy force-pushed the rano/dyn-parse-stdout-stderr branch 2 times, most recently from e93fa89 to 1a7477f Compare November 17, 2022 09:15

rnbguy added 6 commits November 18, 2022 11:39

solve stdout vs stderr

1726803

try except

5130518

remove redundant if

65398a4

process json in separate method

c02efac

use java 17 on ci

436d526

consider optionals

9fed396

rnbguy force-pushed the rano/dyn-parse-stdout-stderr branch from 2b743fd to 9fed396 Compare November 18, 2022 10:39

rnbguy merged commit 2fd6b46 into dev Nov 18, 2022

rnbguy deleted the rano/dyn-parse-stdout-stderr branch November 18, 2022 11:07

Provide feedback