Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Failed to parse source map ... #831

Closed
wisammechano opened this issue Feb 27, 2023 · 3 comments
Closed

Failed to parse source map ... #831

wisammechano opened this issue Feb 27, 2023 · 3 comments

Comments

@wisammechano
Copy link

I am using parse5 in a react app, and the modules are referring to a sourceMap file that is not being found, which is interrupting the build of the app.

I can confirm checking the dist/index.js in npm

Line 45

//# sourceMappingURL=index.js.map

however, there isn't such file relative to path
@prashantpalikhe prashantpalikhe mentioned this issue Apr 10, 2023
Closed
@lunika
Copy link

lunika commented Aug 22, 2023

I confirm we still have this issue with version 7.1.1 of parse5

lunika added a commit to openfun/marsha that referenced this issue Aug 22, 2023
@lunika
⬆️(front) downgrade rehype-mathjax in lib_markdown
c7bae42 
rehype-mathjax@4.0.3 create a warning on the LTI build,
a .map is missing in a dependency of the package.
Dowgrading to 4.0.2 fix the issue.
The dependency having this issue is parse5. An issue is open on their
github repo: inikulin/parse5#831
lunika added a commit to openfun/marsha that referenced this issue Aug 22, 2023
@lunika
⬆️(front) downgrade rehype-mathjax in lib_markdown
5f836db 
rehype-mathjax@4.0.3 create a warning on the LTI build,
a .map is missing in a dependency of the package.
Dowgrading to 4.0.2 fix the issue.
The dependency having this issue is parse5. An issue is open on their
github repo: inikulin/parse5#831
lunika added a commit to openfun/marsha that referenced this issue Aug 22, 2023
@lunika
⬆️(front) downgrade rehype-mathjax in lib_markdown
f12b790 
rehype-mathjax@4.0.3 create a warning on the LTI build,
a .map is missing in a dependency of the package.
Dowgrading to 4.0.2 fix the issue.
The dependency having this issue is parse5. An issue is open on their
github repo: inikulin/parse5#831
lunika added a commit to openfun/marsha that referenced this issue Aug 22, 2023
@lunika
⬆️(front) downgrade rehype-mathjax in lib_markdown
aa5dcfb 
rehype-mathjax@4.0.3 create a warning on the LTI build,
a .map is missing in a dependency of the package.
Dowgrading to 4.0.2 fix the issue.
The dependency having this issue is parse5. An issue is open on their
github repo: inikulin/parse5#831
lunika added a commit to openfun/marsha that referenced this issue Aug 22, 2023
@lunika
⬆️(front) downgrade rehype-mathjax in lib_markdown
aa89e62 
rehype-mathjax@4.0.3 create a warning on the LTI build,
a .map is missing in a dependency of the package.
Dowgrading to 4.0.2 fix the issue.
The dependency having this issue is parse5. An issue is open on their
github repo: inikulin/parse5#831
lunika added a commit to openfun/marsha that referenced this issue Aug 22, 2023
@lunika
⬆️(front) downgrade rehype-mathjax in lib_markdown
f1bc920 
rehype-mathjax@4.0.3 create a warning on the LTI build,
a .map is missing in a dependency of the package.
Dowgrading to 4.0.2 fix the issue.
The dependency having this issue is parse5. An issue is open on their
github repo: inikulin/parse5#831
@43081j
Copy link
Collaborator

43081j commented Sep 4, 2023

fyi @fb55 this is because the files array in the package JSON specifies *.js and not *.js.map

we could either stop generating sourcemaps in prod, or just ship them. what do you think?

@fb55
Copy link
Collaborator

fb55 commented Sep 19, 2023 •
edited
Loading

Source maps reference the original TypeScript files. Most of my packages reference the source files on GitHub (example, longer explanation), which I couldn't figure out how to do with the monorepo setup of parse5.

I would prefer to ship useful source maps, but if that isn't possible, removing the reference seems logical.

antfu added a commit to antfu/parse5-case-sensitive that referenced this issue Jan 25, 2024
@antfu
fix: don't generate sourcemap on build, close inikulin#831
1592aca
This was referenced Jan 25, 2024
Merged
Closed
@fb55 fb55 closed this as completed in 38696be Feb 3, 2024
@fb55 fb55 mentioned this issue Jul 7, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: include sourcemap files in the dist prashantpalikhe/parse5
4 participants
@fb55 @lunika @43081j @wisammechano