Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: include sourcemap files in the dist #890

Closed
wants to merge 1 commit into from

Conversation

prashantpalikhe
Copy link

Fixes #831

@fb55
Copy link
Collaborator

fb55 commented Apr 11, 2023

This will lead to the next issue, which is that source maps reference source files (which aren't part of the package). I've solved this in most of my modules by specifying a sourceRoot that points at the source files on GitHub. That won't work for parse5 however, as we are using tsc --build to build a number of packages at once, and --build does not allow sourceRoot to be set.

The best way forward here is probably to disable source maps during manual builds, or how that the TypeScript team will add support for sourceRoot in --build.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Failed to parse source map ...
2 participants