Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Transactions of the block number in the artifact are never certified by the prover #1762

Closed
2 tasks done
jpraynaud opened this issue Jun 18, 2024 · 0 comments · Fixed by #1779
Closed
2 tasks done

Transactions of the block number in the artifact are never certified by the prover #1762

jpraynaud opened this issue Jun 18, 2024 · 0 comments · Fixed by #1779
Assignees
@Alenar @sfauvel
Labels
bug ⚠️ Something isn't working

Comments

@jpraynaud
Copy link
Member

jpraynaud commented Jun 18, 2024 •
edited by Alenar
Loading

Why

The transactions included in the block number referenced in the artifact (as the last block number signed) are never certified by the prover. Some early investigations have shown that it only the transactions from the penultimate block range are certified.

What

Investigate and fix the problem that prevents some transactions to be certified when they are signed.

How

  • Investigate the problem
  • Fix the problem
@jpraynaud jpraynaud added the bug ⚠️ Something isn't working label Jun 18, 2024
Alenar added a commit that referenced this issue Jun 25, 2024
@Alenar @sfauvel
Fix #1762: CardanoTransactionSnapshot block number is not certified
29006a4 
This is due to the request to retrieve the precomputed block range roots
in database using a exclusive bound comparaison instead of an inclusive,
leading to the exclusion of the last block range root from the retrieved
data.

This means that not only the prover was impacted but the protocol
message generation for the single & multi signatures too.

Co-authored-by: Sébastien Fauvel <sfauvel@users.noreply.github.com>
@Alenar Alenar mentioned this issue Jun 25, 2024
Merged
9 tasks
Alenar added a commit that referenced this issue Jun 26, 2024
@Alenar @sfauvel
Fix #1762: CardanoTransactionSnapshot block number is not certified
5919a4b 
This is due to the request to retrieve the precomputed block range roots
in database using a exclusive bound comparaison instead of an inclusive,
leading to the exclusion of the last block range root from the retrieved
data.

This means that not only the prover was impacted but the protocol
message generation for the single & multi signatures too.

Co-authored-by: Sébastien Fauvel <sfauvel@users.noreply.github.com>
Alenar added a commit that referenced this issue Jun 26, 2024
@Alenar @sfauvel
Fix #1762: CardanoTransactionSnapshot block number is not certified
17c009d 
This is due to the request to retrieve the precomputed block range roots
in database using a exclusive bound comparaison instead of an inclusive,
leading to the exclusion of the last block range root from the retrieved
data.

This means that not only the prover was impacted but the protocol
message generation for the single & multi signatures too.

Co-authored-by: Sébastien Fauvel <sfauvel@users.noreply.github.com>
Alenar added a commit that referenced this issue Jun 26, 2024
@Alenar @sfauvel
Fix #1762: CardanoTransactionSnapshot block number is not certified
7e2e391 
This is due to the request to retrieve the precomputed block range roots
in database using a exclusive bound comparaison instead of an inclusive,
leading to the exclusion of the last block range root from the retrieved
data.

This means that not only the prover was impacted but the protocol
message generation for the single & multi signatures too.

Co-authored-by: Sébastien Fauvel <sfauvel@users.noreply.github.com>
Alenar added a commit that referenced this issue Jun 26, 2024
@Alenar
Merge pull request #1779 from input-output-hk/ensemble/1762/ctx_certi…
e68f628 
…ficate_block_number_is_not_certified

Fix #1762: CardanoTransactionSnapshot block number is not certified
@jpraynaud jpraynaud mentioned this issue Jun 27, 2024
Closed
2 tasks
@Alenar Alenar mentioned this issue Jul 12, 2024
Merged
12 tasks
locallycompact pushed a commit to cardano-scaling/mithril that referenced this issue Sep 27, 2024
@Alenar @sfauvel @locallycompact
Fix input-output-hk#1762: CardanoTransactionSnapshot block number is …
6658314 
…not certified

This is due to the request to retrieve the precomputed block range roots
in database using a exclusive bound comparaison instead of an inclusive,
leading to the exclusion of the last block range root from the retrieved
data.

This means that not only the prover was impacted but the protocol
message generation for the single & multi signatures too.

Co-authored-by: Sébastien Fauvel <sfauvel@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Alenar Alenar

@sfauvel sfauvel

Labels
bug ⚠️ Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix #1762: CardanoTransactionSnapshot block number is not certified input-output-hk/mithril
3 participants
@Alenar @sfauvel @jpraynaud