Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cardano transaction importer does not import the last block advertised as certified #1785

Closed
2 tasks done
jpraynaud opened this issue Jun 27, 2024 · 0 comments
Closed
2 tasks done
Assignees
Labels
bug ⚠️ Something isn't working

Comments

@jpraynaud
Copy link
Member

jpraynaud commented Jun 27, 2024

Why

The Cardano transaction importer does not import the last block displayed as certified:

  • In the aggregator artifact route:
{
  "merkle_root": "05e65f0c58565d1097254ae35432a61a26f06426b2a723ecdac63126bd5d595e",
  "epoch": 493,
  "block_number": 10499370,
  "hash": "877cbbae948ada10c16738d17c53cd98ecf9be43036332a0fff7de5993c99741",
  "certificate_hash": "44c00ffa841ca19529e664f0379481f7afb6e7a76e77ed6fbc413208e81fe0ab",
  "created_at": "2024-06-27T11:00:39.633969066Z"
}
  • In the aggregator logs:
{"msg":"Compute protocol message for CardanoTransactions at block_number: 10499370","v":0,"name":"slog-rs","level":20,"time":"2024-06-27T10:54:03.200240225Z","hostname":"891e6000d0f1","pid":1}
{"msg":"TransactionsImporter will retrieve Cardano transactions between block_number '10499339' and '10499370'","v":0,"name":"slog-rs","level":20,"time":"2024-06-27T10:54:03.200730418Z","hostname":"891e6000d0f1","pid":1}
{"msg":"ChainReaderBlockStreamer polls next","v":0,"name":"slog-rs","level":20,"time":"2024-06-27T10:54:03.201524327Z","hostname":"891e6000d0f1","pid":1}
{"msg":"ChainReaderBlockStreamer received a RollBackward(127916665)","v":0,"name":"slog-rs","level":20,"time":"2024-06-27T10:54:03.202030767Z","hostname":"891e6000d0f1","pid":1}
{"msg":"ChainReaderBlockStreamer polls next","v":0,"name":"slog-rs","level":20,"time":"2024-06-27T10:54:34.895605277Z","hostname":"891e6000d0f1","pid":1}
{"msg":"TransactionsImporter - computing Block Range Roots","v":0,"name":"slog-rs","level":20,"time":"2024-06-27T10:54:34.94627066Z","hostname":"891e6000d0f1","pid":1,"end_block":10499370,"start_block":10499340}
  • In the aggregator database:
+------------------------------------------------------------------+--------------+-----------------------+-------------+------------------------------------------------------------------+
|                         transaction_hash                         | block_number | immutable_file_number | slot_number |                            block_hash                            |
+------------------------------------------------------------------+--------------+-----------------------+-------------+------------------------------------------------------------------+
| 310a311107652bf9b5f7431c13a6df5f9311b267f9dcc2396542c21b158461bb | 10499369     | 0                     | 127917303   | 7509a39a8bb85112d1ff5b0f52ce02b6faa46e71df5885c3a9d56a6d1cfc9b89 |
| 526b31a48c0556d19f93d32180a25e7846b567ea76b7e80bc435b7aa41ccc394 | 10499369     | 0                     | 127917303   | 7509a39a8bb85112d1ff5b0f52ce02b6faa46e71df5885c3a9d56a6d1cfc9b89 |
| f53e463018fb9b45f2ab7426fbef177166a9db78277035c01452c1a7a4062896 | 10499369     | 0                     | 127917303   | 7509a39a8bb85112d1ff5b0f52ce02b6faa46e71df5885c3a9d56a6d1cfc9b89 |
| e0244fa0050980697ab86a61793ececcaab7f7cb36a66ed57703b3c082e881ff | 10499369     | 0                     | 127917303   | 7509a39a8bb85112d1ff5b0f52ce02b6faa46e71df5885c3a9d56a6d1cfc9b89 |
| 54bc2df7c41f03f1e9322b66c33666e7b4cfb5e29fa97991f2276815c036e35e | 10499369     | 0                     | 127917303   | 7509a39a8bb85112d1ff5b0f52ce02b6faa46e71df5885c3a9d56a6d1cfc9b89 |
| 618ad9c930b85e992a11a65909d4761a18d37be57990f44450af40210ebfd015 | 10499369     | 0                     | 127917303   | 7509a39a8bb85112d1ff5b0f52ce02b6faa46e71df5885c3a9d56a6d1cfc9b89 |
| ac14bc095393cb250854d83f8141742a61b8f33a79293e82b34683bfe4de5f81 | 10499369     | 0                     | 127917303   | 7509a39a8bb85112d1ff5b0f52ce02b6faa46e71df5885c3a9d56a6d1cfc9b89 |
| 8f804235559b52ceb54f64941f6faa0591246a4d13214550bdf9645d03cd829b | 10499369     | 0                     | 127917303   | 7509a39a8bb85112d1ff5b0f52ce02b6faa46e71df5885c3a9d56a6d1cfc9b89 |
| cd6295c101ab59de1c6a544c997af0f22354b722f764885e0034768aa135ab2a | 10499369     | 0                     | 127917303   | 7509a39a8bb85112d1ff5b0f52ce02b6faa46e71df5885c3a9d56a6d1cfc9b89 |
| 0f63eaae906d588d43bc1e3c87acf455c0dcc535621e71cc7fc5aa90e22ddf9b | 10499369     | 0                     | 127917303   | 7509a39a8bb85112d1ff5b0f52ce02b6faa46e71df5885c3a9d56a6d1cfc9b89 |
+------------------------------------------------------------------+--------------+-----------------------+-------------+------------------------------------------------------------------+

What

Import the missing block with the Cardano transaction importer:

  • block number in the pending certificate should be: 10499369 (last block number signed by a block range, add an explanation in the code)
  • block number in the artifact should be: 10499369
  • block number in the Cardano transactions store should be at least: 10499369

How

  • Investigate why the latest block is not imported
  • Fix the problem that prevents the last block to be imported

Linked issues

#1762 should have fixed the problem

@jpraynaud jpraynaud added the bug ⚠️ Something isn't working label Jun 27, 2024
Alenar added a commit that referenced this issue Jul 16, 2024
Before its upper bound was exclusive this was fine when others
subsystems were also exclusive but this changed with the fixes
for #1785: now the `until` parameter the last block to include in the
signature instead of being the block were we should stop polling.
Alenar added a commit that referenced this issue Jul 16, 2024
Before its upper bound was exclusive this was fine when others
subsystems were also exclusive but this changed with the fixes
for #1785: now the `until` parameter the last block to include in the
signature instead of being the block were we should stop polling.
locallycompact pushed a commit to cardano-scaling/mithril that referenced this issue Sep 27, 2024
Before its upper bound was exclusive this was fine when others
subsystems were also exclusive but this changed with the fixes
for input-output-hk#1785: now the `until` parameter the last block to include in the
signature instead of being the block were we should stop polling.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug ⚠️ Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants