Skip to content
This repository has been archived by the owner on Jun 2, 2020. It is now read-only.

docs: HTTP API Status Codes #368

Merged
merged 2 commits into from
Nov 6, 2019
Merged

Conversation

lidel
Copy link
Contributor

@lidel lidel commented Nov 5, 2019

This PR updates HTTP API docs with a newly generated version from ipfs-inactive/http-api-docs#23, which adds docs about status codes in HTTP API

Any issues should be reported in the above issue.
This should be merged if upstream PR gets accepted.

Generated with ipfs-inactive/http-api-docs#23

License: MIT
Signed-off-by: Marcin Rataj <lidel@lidel.org>
@lidel
Copy link
Contributor Author

lidel commented Nov 5, 2019

@hsanjuan any idea why cluster panics in https://circleci.com/gh/ipfs/docs/621 ?

panic: runtime error: invalid memory address or nil pointer dereference
[signal SIGSEGV: segmentation violation code=0x1 addr=0x0 pc=0x9c4c80]

goroutine 84 [running]:
main.main.func6.1(0xc00002b574, 0xc0004d6280, 0xc0000b4780)
	github.com/ipfs/ipfs-cluster/cmd/ipfs-cluster-ctl/main.go:436 +0x320
created by main.main.func6
	github.com/ipfs/ipfs-cluster/cmd/ipfs-cluster-ctl/main.go:417 +0x60f
Exited with code 2

@jessicaschilling jessicaschilling added topic/design-content Content design, writing, information architecture dif/easy Someone with a little familiarity can pick up topic/docs Documentation effort/hours Estimated to take one or several hours labels Nov 5, 2019
Copy link
Member

@hsanjuan hsanjuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems there were no api changes at all in last release. nice

@hsanjuan
Copy link
Member

hsanjuan commented Nov 5, 2019

@hsanjuan any idea why cluster panics in https://circleci.com/gh/ipfs/docs/621 ?

panic: runtime error: invalid memory address or nil pointer dereference
[signal SIGSEGV: segmentation violation code=0x1 addr=0x0 pc=0x9c4c80]

goroutine 84 [running]:
main.main.func6.1(0xc00002b574, 0xc0004d6280, 0xc0000b4780)
	github.com/ipfs/ipfs-cluster/cmd/ipfs-cluster-ctl/main.go:436 +0x320
created by main.main.func6
	github.com/ipfs/ipfs-cluster/cmd/ipfs-cluster-ctl/main.go:417 +0x60f
Exited with code 2

I don't know, but this seems to have been fixed...

@jessicaschilling
Copy link
Contributor

@lidel @hsanjuan I'm still seeing the same CircleCI failure. Any ideas?

@hsanjuan
Copy link
Member

hsanjuan commented Nov 5, 2019

@olizilla will update the deploy docker image thing. Then we should just re-trigger the build and it should not panic anymore.

jessicaschilling added a commit to ipfs/ipfs-docs that referenced this pull request Nov 5, 2019
@jessicaschilling
Copy link
Contributor

@olizilla -- can you please let me know when you've deployed the Docker image @hsanjuan refers to in this issue, so this can be merged? Thank you!

@olizilla
Copy link
Contributor

olizilla commented Nov 6, 2019

It's all good to go. We couldn't connect to cluster. It's fixed now.

@jessicaschilling
Copy link
Contributor

@olizilla Thank you so much!

@jessicaschilling jessicaschilling merged commit b04a668 into master Nov 6, 2019
@lidel lidel deleted the feat/http-api-status-codes branch November 6, 2019 19:20
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
dif/easy Someone with a little familiarity can pick up effort/hours Estimated to take one or several hours topic/design-content Content design, writing, information architecture topic/docs Documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants