This repository has been archived by the owner on Sep 22, 2021. It is now read-only.
Document HTTP Status Codes #23
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
License: MIT Signed-off-by: Marcin Rataj <lidel@lidel.org>
also fixed some broken links License: MIT Signed-off-by: Marcin Rataj <lidel@lidel.org>
lidel
added a commit
to ipfs-inactive/docs
that referenced
this pull request
Nov 5, 2019
Generated with ipfs-inactive/http-api-docs#23 License: MIT Signed-off-by: Marcin Rataj <lidel@lidel.org>
This was referenced Nov 5, 2019
hsanjuan
reviewed
Nov 5, 2019
| ) | ||
|
|
||
| replace github.com/go-critic/go-critic v0.0.0-20181204210945-ee9bf5809ead => github.com/go-critic/go-critic v0.3.5-0.20190210220443-ee9bf5809ead |
|
Works for me without hacking the imports |
hsanjuan
approved these changes
Nov 5, 2019
License: MIT Signed-off-by: Hector Sanjuan <hector@protocol.ai>
hsanjuan
force-pushed
the
feat/rpc-docs-and-go-0.13
branch
from
fd54d5b
to
0ef75cd
Compare
|
Nevermind, it seems I'm running a go 1.13 version that still does not fuck up everything. |
|
@lidel @hsanjuan What was your workaround for the CircleCI build test failing? I'd like to merge ipfs-inactive/docs#368 ... |
Stebalien
reviewed
Nov 5, 2019
| * `+"`400`"+` - Malformed RPC, argument type error, etc | ||
| * `+"`403`"+` - RPC call forbidden | ||
|
|
||
| In other words, `+"`500`"+` means that the function _does_ exist, it just failed internally for some reason. To know that reason, you have to look at the "application layer" error (commands lib error). |
There was a problem hiding this comment.
note: functions can also fail with a 200 status code by later returning a trailing error. 😭.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR:
as suggested in Return a 404 instead of a 500 http code when dnslink not found for domain ipfs/kubo#6746 (comment) by @Stebalien
(i will PR to docs.ipfs.io and link to a preview shortly)