Exclude gateway paths from dnslink redirects #518
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Public gateways are often exposed under the same domain name and even tho right now CID-based redirect takes precedence, without this check things could break if we ever do some refactoring and move things around. This does not change anything, just deduplicates code and adds additional check to ensure dnslink redirect should not happen for assets in /ipfs/ and /ipns/ paths
This was referenced Jul 10, 2018
This was referenced Jul 24, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR:
/ipns/{fqdn}/{path}does not happen for/ipfs/,/ipns/and/api/pathsRationale
Public gateways are often exposed under the same domain name (https://ipfs.io) and even
tho right now CID-based redirect takes precedence things could break if we ever do some refactoring and move things around.
Rare edge cases which are fixed by this PR:
/ipns/.