Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update gateway URLs to omit gateway. prefix #536

Closed
wants to merge 1 commit into from
Closed

Conversation

ghost
Copy link

@ghost ghost commented Jul 22, 2018

I noticed occurances of gateway.ipfs.io in my everyday usage of companion -- assuming these were leftovers I went and changed them to just ipfs.io.

Copy link
Member

@lidel lidel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I kinda left that on purpose there 🙃, so user of redirect-based handler in Firefox gets an explicit hint that a HTTP gateway will be used, not the native protocol:

screenshot

I'd left it as-is until we move to dweb.link and subdomains, but if you think it makes sense to change it to ipfs.io, redirect endpoint needs to also be updated in:

https://github.com/ipfs-shipyard/ipfs-companion/blob/0b5635a4dd155d8e996659d2b04c3810b8b00ca7/add-on/src/lib/ipfs-request.js#L203

@ivan386
Copy link

ivan386 commented Jul 24, 2018

Do not use ipfs.io instead of gateway.ipfs.io. It have dnslink record. This a problem when redirect this address to local gateway.

@lidel
Copy link
Member

lidel commented Jul 24, 2018

@ivan386 the problem you describe (dnslink clashing with gateway feature on same host) should be fixed in the latest beta, see PR #518 for details.
It will land to stable soon. The fix landed in v2.4.3.

@ghost
Copy link
Author

ghost commented Aug 14, 2018

I kinda left that on purpose there upside_down_face, so user of redirect-based handler in Firefox gets an explicit hint that a HTTP gateway will be used, not the native protocol [...] I'd left it as-is until we move to dweb.link and subdomains

Understood, makes perfect sense :)

@lidel
Copy link
Member

lidel commented Sep 22, 2018

Alright, we will change this after move to dweb.link :)

@lidel lidel closed this Sep 22, 2018
@lidel lidel deleted the lgierth-patch-1 branch September 22, 2018 23:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants