Change DNS resolution endpoint to allow ipns recursive resolution #959
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@lidel, I believe this one is for you 😊 |
lidel
approved these changes
Jan 17, 2021
There was a problem hiding this comment.
LGTM. Thank you @Ktl-XV ❤️
Given current codebase, I believe we could make it bit faster by passing ?r=false (we only want to know if DNSLink is present, dont need to resolve recursively, especially when people start using /ipns/{libp2p-key} in DNSLink). Will add it before merging.
|
Confirmed DNSLink detection is fast, because it does not resolve libp2p-key based |
Given current codebase, I believe we could make it bit faster by passing
?r=false (we only want to know if DNSLink is present, dont need to
resolve recursively, especially when people start using
/ipns/{libp2p-key} in DNSLink)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #877. I couldn't add any tests because, from what i saw, readDnslinkFromTxtRecord always get mocked. If this is a problem, and someone can point me to the right direction I could add tests.