Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add typescript types to package exports #192

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

jrouleau
Copy link

@jrouleau jrouleau commented Jan 1, 2024

Fixes #191

@HalfdanJ
Copy link

HalfdanJ commented Jan 3, 2024

I ran into the exact same issue, and this solved it perfectly.

@jobjen02
Copy link

jobjen02 commented Feb 6, 2024

Please merge this. We cannot deploy due to this issue!!

@alexciesielski
Copy link

necessary indeed

@jpzwarte
Copy link

Ran into the same thing.

@Regaddi
Copy link

Regaddi commented May 3, 2024

I felt smart in attempting to fix this temporarily using patch-package, but apparently one can't easily patch a package's package.json as part of a patch.

⁉️  Not creating patch file for package 'tinykeys'
⁉️  There don't appear to be any changes.

So the only options are:

  • Fork this package
  • Copy the source (400 bytes, right? MIT License, right?)
  • Get this PR merged and published in a new version

@heyitsarpit
Copy link

@jamiebuilds please merge this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Typescript types not resolving when using tsconfig with moduleResolution: "Bundler"
7 participants