-
-
Notifications
You must be signed in to change notification settings - Fork 611
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add PyPy jobs to PR CI runs #1379
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1379 +/- ##
=======================================
Coverage 99.65% 99.65%
=======================================
Files 33 33
Lines 2940 2940
Branches 308 308
=======================================
Hits 2930 2930
Misses 5 5
Partials 5 5 Continue to review full report at Codecov.
|
@webknjaz Can you fix the tests or at least make them as known failures? |
d8b06cc
to
9798c63
Compare
for more information, see https://pre-commit.ci
@@ -11,6 +11,8 @@ | |||
|
|||
from .constants import MINIMAL_WHEELS_PATH, PACKAGES_PATH | |||
|
|||
is_pypy = "__pypy__" in sys.builtin_module_names |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure what's the canonical way to detect python implementation, maybe platform.python_implementation() == "PyPy"?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That may work too.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay, feel free to ignore the suggestion 👍🏻
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
Ref #1375 (comment)
Changelog-friendly one-liner: Added PyPy jobs to PR builds
Contributor checklist