Update tox environments #1967
Merged
Update tox environments #1967
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since tox==4.9.0, only explicitly declared environments are permitted to run.
|
FTR, failing docs build fixed in #1969. |
|
Thanks @theryanwalker! |
atugushev
commented
Aug 18, 2023
| @@ -151,7 +151,7 @@ jobs: | |||
| pip-version: | |||
| - latest | |||
| env: | |||
| TOXENV: pip${{ matrix.pip-version }} | |||
There was a problem hiding this comment.
874 passed, 1791 warnings in 997.59s (0:16:37)
Wow, 17 minutes on pypy with coverage vs 4 minutes.
@webknjaz, do you remember why the coverage wasn't set up in the first place in #1379? The speed?
There was a problem hiding this comment.
Since we don't have any pypy specific code, we can simply turn off the coverage there.
There was a problem hiding this comment.
I guess because of the slowness.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since
tox==4.9.0, only explicitly declared environments are permitted to run.Refs: tox-dev/tox#3096 (comment)
Contributor checklist
Maintainer checklist
backwards incompatible,feature,enhancement,deprecation,bug,dependency,docsorskip-changelogas they determine changelog listing.