Merge pull request #87 from chelkyl/fix-dry-run-fail

fix(cli): --dry=fail should also fail when either added or removed typings
jeffijoe · Apr 27, 2022 · c5dd49d · c5dd49d
2 parents 3b445b3 + 0d5589d
commit c5dd49d
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 2 deletions.
diff --git a/.travis.yml b/.travis.yml
@@ -1,6 +1,9 @@
 # Oh yeah!
 language: node_js
 
+# Node 18 binaries require glibc >= 2.28
+dist: focal
+
 # Add additional versions here as appropriate.
 node_js:
   - 'stable'

diff --git a/src/cli.ts b/src/cli.ts
@@ -71,8 +71,7 @@ async function run(syncer: ITypeSyncer) {
     )
   if (
     flags.dry === 'fail' &&
-    totals.newTypings > 0 &&
-    totals.removedTypings > 0
+    (totals.newTypings > 0 || totals.removedTypings > 0)
   ) {
     C.error('Typings changed; check failed.')
     process.exitCode = 1