Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cli): --dry=fail should also fail when either added or removed typings #87

Merged
merged 2 commits into from
Apr 27, 2022

Conversation

chelkyl
Copy link
Contributor

@chelkyl chelkyl commented Apr 26, 2022

Now correctly checks even if only added or only removed typings. Sorry for the bad logic in the original PR.

@chelkyl chelkyl changed the title fix: --dry=fail should also fail when either added or removed typings fix(cli): --dry=fail should also fail when either added or removed typings Apr 26, 2022
@coveralls
Copy link
Collaborator

coveralls commented Apr 26, 2022

Coverage Status

Coverage remained the same at 100.0% when pulling 0d5589d on chelkyl:fix-dry-run-fail into 3b445b3 on jeffijoe:master.

@jeffijoe
Copy link
Owner

The CI is failing due to Node 18 being the new stable, but not sure why?

@chelkyl
Copy link
Contributor Author

chelkyl commented Apr 26, 2022

Looks like the build config needs to be updated to choose a distribution newer than xenial.
See: nodejs/node#42351 (comment)

From the NodeJS repo BUILDING.md, Linux binaries are now built on RHEL 8 and the footnote says:

Binaries produced on these systems are compatible with glibc >= 2.28 and libstdc++ >= 6.0.25 (GLIBCXX_3.4.25). These are available on distributions natively supporting GCC 8.1 or higher, such as Debian 10, RHEL 8 and Ubuntu 20.04.

@jeffijoe
Copy link
Owner

I see, thanks! Would you mind updating the travis config in this PR? 😄

focal is the latest Ubuntu version that Travis CI supports
@chelkyl
Copy link
Contributor Author

chelkyl commented Apr 26, 2022

No problem! Updated to focal and it is passing all but 14.
The build failure seems to be a network fluke or something because the error is read ECONNRESET.

@jeffijoe
Copy link
Owner

Nice, thanks! I’ll merge and release tomorrow, appreciate it!

@jeffijoe jeffijoe merged commit c5dd49d into jeffijoe:master Apr 27, 2022
@chelkyl chelkyl deleted the fix-dry-run-fail branch April 29, 2022 05:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants