Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use jekyll-mentions will add extra meta header #37

Closed
crispgm opened this issue Jul 18, 2016 · 8 comments
Closed

Use jekyll-mentions will add extra meta header #37

crispgm opened this issue Jul 18, 2016 · 8 comments
Labels
bug

Comments

@crispgm
Copy link
Member

crispgm commented Jul 18, 2016

Without jekyll-mentions:

<!DOCTYPE html>
<html>

  <head>
  <meta charset="utf-8">

With jekyll-mentions:

<!DOCTYPE html>                                                                                                                                                                   
<html>

  <head>
<meta http-equiv="Content-Type" content="text/html; charset=UTF-8">
  <meta charset="utf-8">

I tried by creating a new project jekyll new test, barely the same outputs.
@parkr
Copy link
Member

parkr commented Jul 19, 2016

Hey! Yeah, we noticed this too, sadly. It seems to come from the way nokogiri writes back documents. If this is missing, it adds it. Am I remembering right, @benbalter? I believe this is a duplicate of jekyll/jemoji#41 then.

@parkr parkr added the bug label Jul 19, 2016
@pathawks
Copy link
Member

sparklemotion/nokogiri#1008

@wkhayrattee
Copy link

wkhayrattee commented Jul 18, 2017 •
edited
Loading

Ok, as per sparklemotion/nokogiri#1008, the solution is to use: nanoc/nanoc#1152 (comment)

Any chance this can be used with jekyll-mentions?

@benbalter
Copy link
Contributor

The proposal there is to move to https://github.com/rubys/nokogumbo. We have a lot of history with nokogiri, and would suggest we evaluate performance, maintenance, and cross-platform compatibility if we're thinking about moving parsers.

@parkr
Copy link
Member

parkr commented Jul 18, 2017

Moreover, html-pipeline is what we use here, so we don't actually own the logic (which is nice). If nokogumbo is a drop-in replacement (or close) and support could be added to html-pipeline, that would make our lives a lot easier.

@ashmaroli ashmaroli mentioned this issue Mar 27, 2018
Merged
spike1292 added a commit to spike1292/spike1292.github.io that referenced this issue Apr 14, 2018
@spike1292
remove jemoji & jekyll-mentions
5e4e9b4 
jekyll/jemoji#41
jekyll/jekyll-mentions#37
@crispgm crispgm closed this as completed Apr 25, 2018
@ashmaroli
Copy link
Member

@crispgm Why did you close this..? Has it been resolved upstream or on master?

@crispgm
Copy link
Member Author

crispgm commented Apr 25, 2018

@ashmaroli it's a common issue across Jekyll's repos and more. so i closed here.

@ashmaroli
Copy link
Member

okay.. I have PRs open proposing a fix if the issue is specific to just jekyll-mentions and jemoji..

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
6 participants
@parkr @pathawks @benbalter @crispgm @wkhayrattee @ashmaroli