Parse only content necessary to mentionify doc #59
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benbalter
reviewed
Apr 25, 2018
lib/jekyll-mentions.rb
Outdated
| @@ -8,24 +8,27 @@ class Mentions | |||
| GITHUB_DOT_COM = "https://github.com".freeze | |||
| BODY_START_TAG = "<body".freeze | |||
|
|
|||
| OPENING_BODY_TAG_REGEX = %r!<body(.*)>\s*! | |||
There was a problem hiding this comment.
Same questions as jekyll/jemoji#74 (comment)... cross-posting theme here for ease of reference:
- Does the
.*need to be non-greedy? (not sure which is more fault tolerant) - Does this need to be case insensitive to allow for
<BODYtags? - Could we simplify/collapse the existing logic with
BODY_START_TAG?
There was a problem hiding this comment.
ashmaroli
force-pushed
the
parse-html-fragment
branch
2 times, most recently
from
14be2e2
to
aeffa1c
Compare
|
@jekyllbot: merge +minor |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of having Nokogiri parse the entire HTML doc and then selectively apply the mentionify_filter to just the contents of the
<body>tag, let's have Nokogiri parse just the<body>tag descendants insteadThe mentionified markup is then inserted back into
doc.outputviaString#<<Fixes #37 as well