Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump aws-load-balancer-controller version and IAM policy content to v2.5.1 #389

Merged
merged 4 commits into from
Jul 4, 2023
Merged

Bump aws-load-balancer-controller version and IAM policy content to v2.5.1 #389

merged 4 commits into from
Jul 4, 2023

Conversation

jenkins-infra-updatecli[bot]
Copy link
Contributor

@jenkins-infra-updatecli jenkins-infra-updatecli bot commented Apr 17, 2023 •
edited
Loading

Bump aws-load-balancer-controller version and IAM policy content to v2.5.1

Report

Source:
	✔ [getLatestContent] (file)
	✔ [getLatestVersion] Retrieve the latest version(githubrelease)


Condition:

Target:
	✔ [updateJSONFile] Update iam-nlb-policy.json file content(file)
	✔ [updateTerraformFile] Update aws-load-balancer-controller version in terraform file(file)

Changelog

Click to expand

Remark

This pull request was automatically created using Updatecli.

Please report any issues with this tool here

@jenkins-infra-bot
chore: Updated the content of the file "/tmp/updatecli/github/jenkins...
c46494f 
... -infra/aws/iam-roles-eks.tf"

Made with ❤️️ by updatecli
@jenkins-infra-bot
chore: Updated the content of the file "/tmp/updatecli/github/jenkins...
fb58b7e 
... -infra/aws/iam-nlb-policy.json"

Made with ❤️️ by updatecli
@jenkins-infra-updatecli jenkins-infra-updatecli bot requested a review from a team April 17, 2023 07:50
@dduportal
Copy link
Contributor

dduportal commented Apr 17, 2023 •
edited
Loading

ref. jenkins-infra/kubernetes-management#3838 (review)

Wow this update is huge: https://github.com/kubernetes-sigs/aws-load-balancer-controller/releases/tag/v2.5.0

The 2 of the 3 Actions Items require carefull deployment:

  • The helm upgrade/apply should be ok
  • But the requirement for annotation related to internet-facing might break the AWS ACP

@jenkins-infra-bot
chore: Updated the content of the file "/tmp/updatecli/github/jenkins...
a0d204b 
... -infra/aws/iam-roles-eks.tf"

Made with ❤️️ by updatecli
@jenkins-infra-updatecli jenkins-infra-updatecli bot changed the title Bump aws-load-balancer-controller version and IAM policy content to v2.5.0 Bump aws-load-balancer-controller version and IAM policy content to v2.5.1 Apr 21, 2023
@dduportal dduportal enabled auto-merge (squash) July 4, 2023 13:10
@dduportal dduportal disabled auto-merge July 4, 2023 13:25
@dduportal dduportal merged commit 6cbb322 into main Jul 4, 2023
1 check passed
@dduportal dduportal deleted the updatecli_d1cc964e9d90d64d56c741419aa8807d06f6d1dcdb65281fc6ae54bfdb2502df branch July 4, 2023 13:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dduportal dduportal dduportal approved these changes

Assignees
No one assigned
Labels
dependencies
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dduportal @jenkins-infra-bot