Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump aws-load-balancer-controller helm chart version to 1.5.4 #3838

Conversation

jenkins-infra-updatecli[bot]
Copy link
Contributor

@jenkins-infra-updatecli jenkins-infra-updatecli bot commented Apr 14, 2023

Bump aws-load-balancer-controller helm chart version

eks/aws-load-balancer-controller Helm Chart

Updated to content "" in file "clusters/eks-public.yaml"

1.5.4
Remark: We couldn't identify a way to automatically retrieve changelog information.
Please use following information to take informed decision

Helm Chart: aws-load-balancer-controller
AWS Load Balancer Controller Helm chart for Kubernetes
Project Home: https://github.com/aws/eks-charts

Version created on the 2023-06-23 01:05:45.305068212 +0000 UTC

Sources:

* https://github.com/aws/eks-charts



URL:

* https://aws.github.io/eks-charts/aws-load-balancer-controller-1.5.4.tgz



Updatecli logo

Created automatically by Updatecli

Options:

Most of Updatecli configuration is done via its manifest(s).

  • If you close this pull request, Updatecli will automatically reopen it, the next time it runs.
  • If you close this pull request and delete the base branch, Updatecli will automatically recreate it, erasing all previous commits made.

Feel free to report any issues at github.com/updatecli/updatecli.
If you find this tool useful, do not hesitate to star our GitHub repository as a sign of appreciation, and/or to tell us directly on our chat!

... -infra/kubernetes-management/clusters/eks-public.yaml"

Made with ❤️️ by updatecli
Copy link
Contributor

@dduportal dduportal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow this update is huge: https://github.com/kubernetes-sigs/aws-load-balancer-controller/releases/tag/v2.5.0

The 2 of the 3 Actions Items require carefull deployment:

  • The helm upgrade/apply should be ok
  • But the requirement for annotation related to internet-facing might break the AWS ACP

Ref. jenkins-infra/aws#389

... -infra/kubernetes-management/clusters/eks-public.yaml"

Made with ❤️️ by updatecli
@jenkins-infra-updatecli jenkins-infra-updatecli bot changed the title Bump aws-load-balancer-controller helm chart version to 1.5.0 Bump aws-load-balancer-controller helm chart version to 1.5.1 Apr 18, 2023
... -infra/kubernetes-management/clusters/eks-public.yaml"

Made with ❤️️ by updatecli
@jenkins-infra-updatecli jenkins-infra-updatecli bot changed the title Bump aws-load-balancer-controller helm chart version to 1.5.1 Bump aws-load-balancer-controller helm chart version to 1.5.2 Apr 20, 2023
Copy link
Member

@lemeurherve lemeurherve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR corresponding to the 1.5.0 helm chart version: aws/eks-charts#933

Action Required

* 🚨 🚨 🚨We've updated the controller manifests, so either use helm upgrade or apply the new manifest. The new controller image is not compatible with manifests from earlier releases, so we don't recommend editing existing deployment and updating the image tag.

* 🚨 🚨 🚨We have made the LBC the default controller for service type LoadBalancer by adding a mutating webhook. Therefore, from v2.5.0, it is required to use k8s 1.22 or later to support the `spec.loadBalancerClass`. This controller creates an `internal` NLB by default. You need to specify the annotation `service.beta.kubernetes.io/aws-load-balancer-scheme: internet-facing` on your service if you want to create an `internet-facing` NLB for your service.

* We have added `subnets`, `InboundCIDRs` and `SSLPolicy` fields in `IngressClassParams`. If you are upgrading the chart via helm upgrade, you need to update the IngressClassParams CRD manually by running `kubectl apply -k "http://github.com/aws/eks-charts/stable/aws-load-balancer-controller//crds?ref=master"`

Whats new

* The AWS LBC provides a mutating webhook for service resources to set the `spec.loadBalancerClass` field for service of type `LoadBalancer` on create. This makes the AWS LBC the default controller for service of type `LoadBalancer`.  You can disable this feature and revert to set CCM as the default by setting the helm chart value `enableServiceMutatorWebhook`  to `false`.

* You can set the default target type for the load balancer target groups. For helm chart, you can specify the `defaultTargetType` value during chart install/upgrade.

* Fields `subnets`, `InboundCIDRs` and `SSLPolicy` in `IngressClassParams`

Enhancements

* Update controller runtime

* Add a validation step on service annotation [`service.beta.kubernetes.io/aws-load-balancer-ssl-ports`](http://service.beta.kubernetes.io/aws-load-balancer-ssl-ports)

* Handle the validation error on ingress annotation `alb.ingress.kubernetes.io/conditions.${conditions-name}`

* Enable `EndpointsFailOpen` by default

* Allow multiple TLS certificate for the same host for ALB during certificate discovery

* Migrate to ConfigMap leases for the leader election

* Documentation enhancement

https://github.com/aws/eks-charts/pull/933/files

Needs more attention

... -infra/kubernetes-management/clusters/eks-public.yaml"

Made with ❤️️ by updatecli
@jenkins-infra-updatecli jenkins-infra-updatecli bot changed the title Bump aws-load-balancer-controller helm chart version to 1.5.2 Bump aws-load-balancer-controller helm chart version to 1.5.3 May 20, 2023
@jenkins-infra-updatecli jenkins-infra-updatecli bot changed the title Bump aws-load-balancer-controller helm chart version to 1.5.3 Bump aws-load-balancer-controller helm chart version to 1.5.4 Jun 23, 2023
@lemeurherve
Copy link
Member

Related: jenkins-infra/helpdesk#3582 (comment)

Copy link
Contributor

@dduportal dduportal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's roll!

jenkins-infra/jenkins-infra#2949 => no risk to break the service

@dduportal dduportal enabled auto-merge (squash) July 4, 2023 13:09
@dduportal dduportal disabled auto-merge July 4, 2023 13:09
@dduportal dduportal merged commit d09d9ae into main Jul 4, 2023
6 checks passed
@dduportal dduportal deleted the updatecli_3566ea2aefb86371614892604ac13a329a8bf1b301ccabfdef20e091112b8d1d branch July 4, 2023 13:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants