Fix nodelist readonly length #349
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
childNodes.length is readonly, and is also updated live when the DOM is updated. See: https://developer.mozilla.org/en-US/docs/Web/API/NodeList In strict mode attempting to set `childNodes.length` throws an error.
|
Thanks! We still need to remove all the children from the gradient tag though. I'll update your PR to handle that. |
|
haha, ye, I was just about to say hang on a second... I've got a failing case that's not yet tested. Still evaluating the issue... but looks like a gradient is not being applied. Will follow up once I figure out what's going on. |
|
I think it should work now. But, if there are additional things you want to add I'll wait to merge. Thanks for the PR! |
|
cool, I'm gonna merge these changes back into my branch, and see what's going on with the issue I'm experiencing in my project. Hopefully a quick fix, but I'll likely get back to you tomorrow :) |
|
alright, your commits fixed my issues! Good to go to merge. Thanks @jonobr1 |
elShiaLabeouf
pushed a commit
to elShiaLabeouf/two.js
that referenced
this pull request
Dec 17, 2021
Fix nodelist readonly length
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When running Two.js in an environment where
use strict;is used, settingchildNodes.lengthto anything throws an error because it's actually a read-only property.Also,
childNodesis live, so updates to the DOM will be reflected in thelengthproperty automatically.All tests are passing with this update.