Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix nodelist readonly length #349

Merged
merged 5 commits into from
Feb 7, 2019
Merged

Fix nodelist readonly length #349

merged 5 commits into from
Feb 7, 2019

Commits on Feb 7, 2019

  1. don't set length on childnodes 

    childNodes.length is readonly, and is also updated live when the DOM is updated. See:
https://developer.mozilla.org/en-US/docs/Web/API/NodeList

In strict mode attempting to set `childNodes.length` throws an error.
    @larrybotha
    larrybotha committed Feb 7, 2019
    Configuration menu
    Copy the full SHA
    eb884cf View commit details
    Browse the repository at this point in the history

  2. build

    @larrybotha
    larrybotha committed Feb 7, 2019
    Configuration menu
    Copy the full SHA
    bfcbf0a View commit details
    Browse the repository at this point in the history

  3. Remove child elements on Gradients in SvgRenderer

    @jonobr1
    jonobr1 committed Feb 7, 2019
    Configuration menu
    Copy the full SHA
    a72cd91 View commit details
    Browse the repository at this point in the history

  4. Updated Builds

    @jonobr1
    jonobr1 committed Feb 7, 2019
    Configuration menu
    Copy the full SHA
    0aabb4c View commit details
    Browse the repository at this point in the history

  5. Delete arrow.js

    @jonobr1
    jonobr1 authored Feb 7, 2019
    Configuration menu
    Copy the full SHA
    b72f8ec View commit details
    Browse the repository at this point in the history