Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[4.1] add rel=\"noopener noreferrer\" for target=\"blank\" links #37014

Merged
merged 3 commits into from
Feb 22, 2022

Conversation

tecpromotion
Copy link
Contributor

@tecpromotion tecpromotion commented Feb 12, 2022

Summary of Changes

during the translation i stumbled across some links with target=_blank without rel="noopener noreferrer".
A global search found only 9 more occurrences.

Testing Instructions

check if the links still work

Actual result BEFORE applying this Pull Request

e.g.
PLG_SYSTEM_JOOA11Y_HEADING_FIRST="The first heading on a page should usually be a Heading 1 or Heading 2. Heading 1 should be the start of the main content section, and is the main heading that describes the overall purpose of the page. Learn more about <a href=\"https://www.w3.org/WAI/tutorials/page-structure/headings/\" target=\"_blank\">Heading Structure.</a>"

Expected result AFTER applying this Pull Request

e.g.
PLG_SYSTEM_JOOA11Y_HEADING_FIRST="The first heading on a page should usually be a Heading 1 or Heading 2. Heading 1 should be the start of the main content section, and is the main heading that describes the overall purpose of the page. Learn more about <a href=\"https://www.w3.org/WAI/tutorials/page-structure/headings/\" target=\"_blank\" rel=\"noopener noreferrer\">Heading Structure.</a>"

Documentation Changes Required

.

@joomla-cms-bot joomla-cms-bot added Language Change This is for Translators PR-4.1-dev labels Feb 12, 2022
@Quy
Copy link
Contributor

Quy commented Feb 12, 2022

I have tested this item ✅ successfully on 2c407d7


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37014.

1 similar comment
@khu5h1
Copy link
Contributor

khu5h1 commented Feb 14, 2022

I have tested this item ✅ successfully on 2c407d7


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37014.

@Quy Quy removed the Language Change This is for Translators label Feb 14, 2022
@Quy
Copy link
Contributor

Quy commented Feb 14, 2022

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37014.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Feb 14, 2022
@brianteeman brianteeman mentioned this pull request Feb 18, 2022
19 tasks
@joomla-cms-bot joomla-cms-bot added the Language Change This is for Translators label Feb 20, 2022
@bembelimen bembelimen merged commit 1b83de1 into joomla:4.1-dev Feb 22, 2022
@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Feb 22, 2022
@bembelimen
Copy link
Contributor

Thx

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Language Change This is for Translators
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants