-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[4.1] Remove Bootstrap tooltip #37238
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I have tested this item ✅ successfully on 15faa91 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37238. |
i agree the current code is wrong but i dont agree in adding the tip. its not in any other list |
Changed. Thanks. |
Quy
changed the title
[4.1] Remove Bootstrap tooltip to use default tooltip
[4.1] Remove Bootstrap tooltip
Mar 10, 2022
I have tested this item ✅ successfully on 9cb22cc This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37238. |
1 similar comment
I have tested this item ✅ successfully on 9cb22cc This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37238. |
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37238. |
Thanks. |
Kostelano
added a commit
to JPathRu/localisation
that referenced
this pull request
Mar 15, 2022
joomla/joomla-cms#35323 + joomla/joomla-cms#35693 + joomla/joomla-cms#36279 - (у нас не было термина "рендеринг") joomla/joomla-cms#36714 + joomla/joomla-cms#36865 + joomla/joomla-cms#36875 + joomla/joomla-cms#37014 + joomla/joomla-cms#37033 + joomla/joomla-cms#37043 - (только для других языков) joomla/joomla-cms#37049 - (только для en-GB) joomla/joomla-cms#37092 + joomla/joomla-cms#37104 + joomla/joomla-cms#37119 + joomla/joomla-cms#37129 + joomla/joomla-cms#37133 + joomla/joomla-cms#37196 + joomla/joomla-cms#37203 + joomla/joomla-cms#37224 + joomla/joomla-cms#37238 +
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of Changes
Due to an incorrect selector, the Bootstrap tooltip did not display. This PR removes the use of Bootstrap tooltip markup and update the title attribute to include the site name to be consistent with other lists.
Testing Instructions
Go to System > Update Sites
Move cursor over a site.