Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[4.1] Remove Bootstrap tooltip #37238

Merged
merged 5 commits into from
Mar 11, 2022
Merged

Conversation

Quy
Copy link
Contributor

@Quy Quy commented Mar 9, 2022

Summary of Changes

Due to an incorrect selector, the Bootstrap tooltip did not display. This PR removes the use of Bootstrap tooltip markup and update the title attribute to include the site name to be consistent with other lists.

Testing Instructions

Go to System > Update Sites
Move cursor over a site.

@ChristineWk
Copy link

I have tested this item ✅ successfully on 15faa91


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37238.

@brianteeman
Copy link
Contributor

i agree the current code is wrong but i dont agree in adding the tip. its not in any other list

@joomla-cms-bot joomla-cms-bot added the Language Change This is for Translators label Mar 9, 2022
@Quy
Copy link
Contributor Author

Quy commented Mar 10, 2022

Changed. Thanks.

@Quy Quy changed the title [4.1] Remove Bootstrap tooltip to use default tooltip [4.1] Remove Bootstrap tooltip Mar 10, 2022
@brianteeman
Copy link
Contributor

I have tested this item ✅ successfully on 9cb22cc


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37238.

1 similar comment
@ChristineWk
Copy link

I have tested this item ✅ successfully on 9cb22cc


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37238.

@Quy
Copy link
Contributor Author

Quy commented Mar 10, 2022

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37238.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Mar 10, 2022
@richard67 richard67 merged commit 1df9d40 into joomla:4.1-dev Mar 11, 2022
@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Mar 11, 2022
@richard67
Copy link
Member

Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Language Change This is for Translators
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants