Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[4.2]Corrected different multi-select behavior in media manage #39785

Closed
wants to merge 4 commits into from
Closed

[4.2]Corrected different multi-select behavior in media manage #39785

wants to merge 4 commits into from

Conversation

rajputanuj31
Copy link
Contributor

@rajputanuj31 rajputanuj31 commented Feb 4, 2023

Pull Request #33637

Summary of Changes
Multi select without using shift key

Testing Instructions

Open Media
Try to Select media manager files.

Actual result BEFORE applying this Pull Request

You can not select multiple items without holding the shift key.

Expected result AFTER applying this Pull Request

You can select multiple items by holding ctrl key & clicking on items.
You can also select all files between two selected files by holding shift key.

Media.-.Demo-.Trim.mp4

@joomla-cms-bot joomla-cms-bot added NPM Resource Changed This Pull Request can't be tested by Patchtester PR-4.2-dev labels Feb 4, 2023
@rajputanuj31 rajputanuj31 changed the title Corrected different multi-select behavior in media manage [4.2]Corrected different multi-select behavior in media manage Feb 4, 2023
@dgrammatiko
Copy link
Contributor

@rajputanuj31 I think the expected behaviour involves both ctrl and shift keys, I had started fixing it here: #39679 (comment) (it needs the shift key logic as explained in that comment)

@richard67
Copy link
Member

Besides this, the javascript linter at the drone CI tests reports errors here https://ci.joomla.org/joomla/joomla-cms/61584/1/26 :

+ npm run lint:js

> joomla@4.0.0 lint:js
> eslint --config build/.eslintrc --ignore-pattern '/media/' --ext .es6.js,.es6,.vue .

/********/src/administrator/components/com_media/resources/scripts/components/browser/items/item.es6.js
  117:17  error  'event' is defined but never used  no-unused-vars

/********/src/administrator/components/com_media/resources/scripts/components/browser/items/row.vue
  96:13  error  'event' is defined but never used  no-unused-vars

✖ 2 problems (2 errors, 0 warnings)

@rajputanuj31
Copy link
Contributor Author

@rajputanuj31 I think the expected behaviour involves both ctrl and shift keys, I had started fixing it here: #39679 (comment) (it needs the shift key logic as explained in that comment)

@dgrammatiko Is this looks fine??

Media.-Trim-2.mp4

@dgrammatiko
Copy link
Contributor

@rajputanuj31 please rebase this pr to 4.3-dev

@rajputanuj31 rajputanuj31 closed this by deleting the head repository Feb 8, 2023
@rajputanuj31
Copy link
Contributor Author

Please Review this PR #39824.
Previously I have forked only 4.2 branch so for rebasing had to fork again 🙃

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
NPM Resource Changed This Pull Request can't be tested by Patchtester
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants