-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[5.1] Corrected different multi-select behavior in media manager. #39824
base: 5.1-dev
Are you sure you want to change the base?
Conversation
@rajputanuj31 When you create a PR, why do you delete stuff which is prepared in the description, like e.g. the "Pull request for issue #..." at the top, or the section about documentation, which requires the right check boxes to be checked? We do not have that stuff for nothing in our pull request description template. So please add the |
There are unrelated files in this pull request :( |
This reverts commit a8aa3ef.
Fixed. |
administrator/components/com_media/resources/scripts/components/browser/items/item.es6.js
Outdated
Show resolved
Hide resolved
administrator/components/com_media/resources/scripts/components/browser/items/item.es6.js
Outdated
Show resolved
Hide resolved
@rajputanuj31 can you check if the |
it's working fine. |
administrator/components/com_media/resources/scripts/components/browser/items/item.es6.js
Outdated
Show resolved
Hide resolved
Please add some inline comments, so we can follow your code. Actually it is hard to understand what exactly is going on with all these if else conditions. I would also recommend that you do early return instead of so many else statements. |
@brianteeman It's working perfectly in my local machine. what should I do now? |
do you have exactly the same images as I have? |
Yes I do have the same images. |
all three? |
Yes now I am also facing the same issue. I am trying to debug it. |
administrator/components/com_media/resources/scripts/components/browser/utils/utils.es6.js
Show resolved
Hide resolved
…s/browser/utils/utils.es6.js Co-authored-by: Dimitris Grammatikogiannis <dg@dgrammatiko.dev>
@dgrammatiko @laoneo @brianteeman please test the PR. |
Hey @laoneo @dgrammatiko @brianteeman @Hackwar I think this PR is ready so please test it. If PR is not ready please leave a comment. |
I have tested this item 🔴 unsuccessfully on f971327 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39824. |
@rajputanuj31 can you look at the response by @ceford please? |
Its working perfectly in my local machine. |
Mac ctrl (in this context) is the apple button (command) |
I tested it and it didn't pass. patchtest.mp4 |
Pull Request for issue #33637
Summary of Changes
Multi select without using shift key
Testing Instructions
Open Media
Try to Select media manager files.
Actual result BEFORE applying this Pull Request
You can not select multiple items without holding the shift key.
Expected result AFTER applying this Pull Request
You can select multiple items by holding
ctrl key
& clicking on items.You can also select all files between two selected files by holding
shift key
.Media.-Trim-2.mp4