-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[4.3][Guided Tours] Make filter search tooltip consistent #40197
Conversation
The PR is correct for consistency but if you check you will see that there is no code for searching the descrption |
Please see this merged PR #40118 to see code for description search. |
I have tested this item ✅ successfully on 498f435 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/40197. |
no thats not it. the query is supposed to take account of that (and it works for the title) |
I have tested this item ✅ successfully on 498f435 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/40197. |
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/40197. |
* add strings joomla/joomla-cms#39902 * add copyright J!German * translation * translation * fix * translation * update strings joomla/joomla-cms#40197 * update strings joomla/joomla-cms#40308 * remove strings joomla/joomla-cms#40319 * update/remove strings joomla/joomla-cms#40301 * update strings joomla/joomla-cms#40318 * translation * fix * wording test * Update administrator/language/de-DE/com_guidedtours.sys.ini Co-authored-by: heelc29 <66922325+heelc29@users.noreply.github.com> * translation * sounds better * translate guided tour tour * translate COM_GUIDEDTOURS_TOUR_USERS * translate COM_GUIDEDTOURS_TOUR_MENUS * translate COM_GUIDEDTOURS_TOUR_CATEGORIES * translate COM_GUIDEDTOURS_TOUR_TAGS * translate COM_GUIDEDTOURS_TOUR_BANNERS * translate COM_GUIDEDTOURS_TOUR_CONTACTS * translate COM_GUIDEDTOURS_TOUR_NEWSFEEDS * translate COM_GUIDEDTOURS_TOUR_SMARTSEARCH * translate COM_GUIDEDTOURS_TOUR_GUIDEDTOURSTEPS_STEP * wording Schaltfläche ist dort zu lang und besser in der Description (meist) aufgehoben * fix #2781 * Update administrator/language/de-DE/com_guidedtours.sys.ini Co-authored-by: Tobias Zulauf <zero-24@users.noreply.github.com> * Update administrator/language/de-DE/com_guidedtours.sys.ini Co-authored-by: Tobias Zulauf <zero-24@users.noreply.github.com> * Update administrator/language/de-DE/com_guidedtours.sys.ini Co-authored-by: Tobias Zulauf <zero-24@users.noreply.github.com> * Update administrator/language/de-DE/com_guidedtours.sys.ini Co-authored-by: Tobias Zulauf <zero-24@users.noreply.github.com> * Update administrator/language/de-DE/com_guidedtours.sys.ini Co-authored-by: Tobias Zulauf <zero-24@users.noreply.github.com> * Update administrator/language/de-DE/com_guidedtours.sys.ini Co-authored-by: Tobias Zulauf <zero-24@users.noreply.github.com> * Update administrator/language/de-DE/com_guidedtours.sys.ini Co-authored-by: Tobias Zulauf <zero-24@users.noreply.github.com> * Update administrator/language/de-DE/com_guidedtours.sys.ini Co-authored-by: Tobias Zulauf <zero-24@users.noreply.github.com> * spelling mistakes * Update administrator/language/de-DE/com_guidedtours.sys.ini Co-authored-by: heelc29 <66922325+heelc29@users.noreply.github.com> * Update administrator/language/de-DE/com_guidedtours.sys.ini Co-authored-by: heelc29 <66922325+heelc29@users.noreply.github.com> * Update administrator/language/de-DE/com_guidedtours.sys.ini Co-authored-by: heelc29 <66922325+heelc29@users.noreply.github.com> * Update administrator/language/de-DE/com_guidedtours.sys.ini * Update administrator/language/de-DE/com_guidedtours.sys.ini * spelling * Update administrator/language/de-DE/com_guidedtours.sys.ini Co-authored-by: heelc29 <66922325+heelc29@users.noreply.github.com> * Update administrator/language/de-DE/com_guidedtours.sys.ini Co-authored-by: heelc29 <66922325+heelc29@users.noreply.github.com> * Update administrator/language/de-DE/com_guidedtours.sys.ini Co-authored-by: heelc29 <66922325+heelc29@users.noreply.github.com> * Update administrator/language/de-DE/com_guidedtours.sys.ini Co-authored-by: heelc29 <66922325+heelc29@users.noreply.github.com> * Update administrator/language/de-DE/com_guidedtours.sys.ini Co-authored-by: heelc29 <66922325+heelc29@users.noreply.github.com> --------- Co-authored-by: Stefan Wendhausen <stefan.wendhausen@tec-promotion.de> Co-authored-by: Tobias Zulauf <zero-24@users.noreply.github.com>
Summary of Changes
Make filter search tooltip consistent with other tooltips.
Testing Instructions
Code review.