-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[4.3] Guided Tours specifier %s to %d #40318
Merged
obuisard
merged 2 commits into
joomla:4.3-dev
from
heelc29:4.3/com_guidedtours/lang-specifier
Apr 4, 2023
Merged
[4.3] Guided Tours specifier %s to %d #40318
obuisard
merged 2 commits into
joomla:4.3-dev
from
heelc29:4.3/com_guidedtours/lang-specifier
Apr 4, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I have tested this item ✅ successfully on 6ff1a71 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/40318. |
1 similar comment
I have tested this item ✅ successfully on 6ff1a71 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/40318. |
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/40318. |
Thank you @heelc29 for the PR |
heelc29
added a commit
to heelc29/joomla
that referenced
this pull request
Apr 4, 2023
zero-24
added a commit
to joomlagerman/joomla
that referenced
this pull request
Apr 17, 2023
* add strings joomla/joomla-cms#39902 * add copyright J!German * translation * translation * fix * translation * update strings joomla/joomla-cms#40197 * update strings joomla/joomla-cms#40308 * remove strings joomla/joomla-cms#40319 * update/remove strings joomla/joomla-cms#40301 * update strings joomla/joomla-cms#40318 * translation * fix * wording test * Update administrator/language/de-DE/com_guidedtours.sys.ini Co-authored-by: heelc29 <66922325+heelc29@users.noreply.github.com> * translation * sounds better * translate guided tour tour * translate COM_GUIDEDTOURS_TOUR_USERS * translate COM_GUIDEDTOURS_TOUR_MENUS * translate COM_GUIDEDTOURS_TOUR_CATEGORIES * translate COM_GUIDEDTOURS_TOUR_TAGS * translate COM_GUIDEDTOURS_TOUR_BANNERS * translate COM_GUIDEDTOURS_TOUR_CONTACTS * translate COM_GUIDEDTOURS_TOUR_NEWSFEEDS * translate COM_GUIDEDTOURS_TOUR_SMARTSEARCH * translate COM_GUIDEDTOURS_TOUR_GUIDEDTOURSTEPS_STEP * wording Schaltfläche ist dort zu lang und besser in der Description (meist) aufgehoben * fix #2781 * Update administrator/language/de-DE/com_guidedtours.sys.ini Co-authored-by: Tobias Zulauf <zero-24@users.noreply.github.com> * Update administrator/language/de-DE/com_guidedtours.sys.ini Co-authored-by: Tobias Zulauf <zero-24@users.noreply.github.com> * Update administrator/language/de-DE/com_guidedtours.sys.ini Co-authored-by: Tobias Zulauf <zero-24@users.noreply.github.com> * Update administrator/language/de-DE/com_guidedtours.sys.ini Co-authored-by: Tobias Zulauf <zero-24@users.noreply.github.com> * Update administrator/language/de-DE/com_guidedtours.sys.ini Co-authored-by: Tobias Zulauf <zero-24@users.noreply.github.com> * Update administrator/language/de-DE/com_guidedtours.sys.ini Co-authored-by: Tobias Zulauf <zero-24@users.noreply.github.com> * Update administrator/language/de-DE/com_guidedtours.sys.ini Co-authored-by: Tobias Zulauf <zero-24@users.noreply.github.com> * Update administrator/language/de-DE/com_guidedtours.sys.ini Co-authored-by: Tobias Zulauf <zero-24@users.noreply.github.com> * spelling mistakes * Update administrator/language/de-DE/com_guidedtours.sys.ini Co-authored-by: heelc29 <66922325+heelc29@users.noreply.github.com> * Update administrator/language/de-DE/com_guidedtours.sys.ini Co-authored-by: heelc29 <66922325+heelc29@users.noreply.github.com> * Update administrator/language/de-DE/com_guidedtours.sys.ini Co-authored-by: heelc29 <66922325+heelc29@users.noreply.github.com> * Update administrator/language/de-DE/com_guidedtours.sys.ini * Update administrator/language/de-DE/com_guidedtours.sys.ini * spelling * Update administrator/language/de-DE/com_guidedtours.sys.ini Co-authored-by: heelc29 <66922325+heelc29@users.noreply.github.com> * Update administrator/language/de-DE/com_guidedtours.sys.ini Co-authored-by: heelc29 <66922325+heelc29@users.noreply.github.com> * Update administrator/language/de-DE/com_guidedtours.sys.ini Co-authored-by: heelc29 <66922325+heelc29@users.noreply.github.com> * Update administrator/language/de-DE/com_guidedtours.sys.ini Co-authored-by: heelc29 <66922325+heelc29@users.noreply.github.com> * Update administrator/language/de-DE/com_guidedtours.sys.ini Co-authored-by: heelc29 <66922325+heelc29@users.noreply.github.com> --------- Co-authored-by: Stefan Wendhausen <stefan.wendhausen@tec-promotion.de> Co-authored-by: Tobias Zulauf <zero-24@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of Changes
Apply changes from #34845 for guided tours
Testing Instructions
perform several actions publish/unpublish/trash/... for tours/steps
Actual result BEFORE applying this Pull Request
Expected result AFTER applying this Pull Request
Link to documentations
Please select: