Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[4.3] Guided Tours specifier %s to %d #40318

Merged
merged 2 commits into from
Apr 4, 2023

Conversation

heelc29
Copy link
Contributor

@heelc29 heelc29 commented Apr 3, 2023

Summary of Changes

Apply changes from #34845 for guided tours

Testing Instructions

perform several actions publish/unpublish/trash/... for tours/steps

Actual result BEFORE applying this Pull Request

image
image

Expected result AFTER applying this Pull Request

image
image

Link to documentations

Please select:

  • No documentation changes for docs.joomla.org needed
  • No documentation changes for manual.joomla.org needed

@joomla-cms-bot joomla-cms-bot added Language Change This is for Translators PR-4.3-dev labels Apr 3, 2023
@Quy
Copy link
Contributor

Quy commented Apr 3, 2023

I have tested this item ✅ successfully on 6ff1a71


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/40318.

1 similar comment
@alikon
Copy link
Contributor

alikon commented Apr 3, 2023

I have tested this item ✅ successfully on 6ff1a71


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/40318.

@joomla-cms-bot joomla-cms-bot removed Language Change This is for Translators PR-4.3-dev labels Apr 3, 2023
@alikon
Copy link
Contributor

alikon commented Apr 3, 2023

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/40318.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Apr 3, 2023
@richard67 richard67 added Language Change This is for Translators PR-4.3-dev labels Apr 3, 2023
@obuisard obuisard added this to the Joomla! 4.3.0 milestone Apr 4, 2023
@obuisard obuisard merged commit a575900 into joomla:4.3-dev Apr 4, 2023
@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Apr 4, 2023
@obuisard
Copy link
Contributor

obuisard commented Apr 4, 2023

Thank you @heelc29 for the PR

@heelc29 heelc29 deleted the 4.3/com_guidedtours/lang-specifier branch April 4, 2023 16:01
heelc29 added a commit to heelc29/joomla that referenced this pull request Apr 4, 2023
zero-24 added a commit to joomlagerman/joomla that referenced this pull request Apr 17, 2023
* add strings

joomla/joomla-cms#39902

* add copyright J!German

* translation

* translation

* fix

* translation

* update strings

joomla/joomla-cms#40197

* update strings

joomla/joomla-cms#40308

* remove strings

joomla/joomla-cms#40319

* update/remove strings

joomla/joomla-cms#40301

* update strings

joomla/joomla-cms#40318

* translation

* fix

* wording test

* Update administrator/language/de-DE/com_guidedtours.sys.ini

Co-authored-by: heelc29 <66922325+heelc29@users.noreply.github.com>

* translation

* sounds better

* translate guided tour tour

* translate COM_GUIDEDTOURS_TOUR_USERS

* translate COM_GUIDEDTOURS_TOUR_MENUS

* translate COM_GUIDEDTOURS_TOUR_CATEGORIES

* translate COM_GUIDEDTOURS_TOUR_TAGS

* translate COM_GUIDEDTOURS_TOUR_BANNERS

* translate COM_GUIDEDTOURS_TOUR_CONTACTS

* translate COM_GUIDEDTOURS_TOUR_NEWSFEEDS

* translate COM_GUIDEDTOURS_TOUR_SMARTSEARCH

* translate COM_GUIDEDTOURS_TOUR_GUIDEDTOURSTEPS_STEP

* wording

Schaltfläche ist dort zu lang und besser in der Description (meist) aufgehoben

* fix #2781

* Update administrator/language/de-DE/com_guidedtours.sys.ini

Co-authored-by: Tobias Zulauf <zero-24@users.noreply.github.com>

* Update administrator/language/de-DE/com_guidedtours.sys.ini

Co-authored-by: Tobias Zulauf <zero-24@users.noreply.github.com>

* Update administrator/language/de-DE/com_guidedtours.sys.ini

Co-authored-by: Tobias Zulauf <zero-24@users.noreply.github.com>

* Update administrator/language/de-DE/com_guidedtours.sys.ini

Co-authored-by: Tobias Zulauf <zero-24@users.noreply.github.com>

* Update administrator/language/de-DE/com_guidedtours.sys.ini

Co-authored-by: Tobias Zulauf <zero-24@users.noreply.github.com>

* Update administrator/language/de-DE/com_guidedtours.sys.ini

Co-authored-by: Tobias Zulauf <zero-24@users.noreply.github.com>

* Update administrator/language/de-DE/com_guidedtours.sys.ini

Co-authored-by: Tobias Zulauf <zero-24@users.noreply.github.com>

* Update administrator/language/de-DE/com_guidedtours.sys.ini

Co-authored-by: Tobias Zulauf <zero-24@users.noreply.github.com>

* spelling mistakes

* Update administrator/language/de-DE/com_guidedtours.sys.ini

Co-authored-by: heelc29 <66922325+heelc29@users.noreply.github.com>

* Update administrator/language/de-DE/com_guidedtours.sys.ini

Co-authored-by: heelc29 <66922325+heelc29@users.noreply.github.com>

* Update administrator/language/de-DE/com_guidedtours.sys.ini

Co-authored-by: heelc29 <66922325+heelc29@users.noreply.github.com>

* Update administrator/language/de-DE/com_guidedtours.sys.ini

* Update administrator/language/de-DE/com_guidedtours.sys.ini

* spelling

* Update administrator/language/de-DE/com_guidedtours.sys.ini

Co-authored-by: heelc29 <66922325+heelc29@users.noreply.github.com>

* Update administrator/language/de-DE/com_guidedtours.sys.ini

Co-authored-by: heelc29 <66922325+heelc29@users.noreply.github.com>

* Update administrator/language/de-DE/com_guidedtours.sys.ini

Co-authored-by: heelc29 <66922325+heelc29@users.noreply.github.com>

* Update administrator/language/de-DE/com_guidedtours.sys.ini

Co-authored-by: heelc29 <66922325+heelc29@users.noreply.github.com>

* Update administrator/language/de-DE/com_guidedtours.sys.ini

Co-authored-by: heelc29 <66922325+heelc29@users.noreply.github.com>

---------

Co-authored-by: Stefan Wendhausen <stefan.wendhausen@tec-promotion.de>
Co-authored-by: Tobias Zulauf <zero-24@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Language Change This is for Translators
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants