[cypress] System Tests fixes #43620, fixes #43622 #43656
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- fixes issue joomla#43620 - if no 'rm' command is available on Windows - fixes issue joomla#43622 - if cmsPath is set - custom task 'deleteFolder' can also delete a file and ignores if the file does not exist -> exactly what we need - once PR is merged i will create the next PR to rename 'deleteFolder' as 'deleteRelativePath' and also 'writeFile' as 'writeRelativeFile' to better represent the functions
This was referenced Jun 15, 2024
|
I have tested this item ✅ successfully on 771522b This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43656. |
|
Thanks! |
muhme
added a commit
to muhme/joomla-cms
that referenced
this pull request
Jun 17, 2024
- rename deleteFolder > deleteRelativePath
- to respect the custom task also deletes files and it does it relative to cmsPath
- rename writeFile > writeRelativeFile
- to unify task naming and to clarify it write relative to cmsPath
- additinal:
- small comment enhancements
- using const name 'path' from require('path');
- no functionality is changed, only method name, variable name and comment changes
- this is a follow-up to PR joomla#43656
- tested on branch dev-4.4 successfully
laoneo
pushed a commit
that referenced
this pull request
Jun 20, 2024
* [cypress] Rename deleteFolder to clarify function
- rename deleteFolder > deleteRelativePath
- to respect the custom task also deletes files and it does it relative to cmsPath
- rename writeFile > writeRelativeFile
- to unify task naming and to clarify it write relative to cmsPath
- additinal:
- small comment enhancements
- using const name 'path' from require('path');
- no functionality is changed, only method name, variable name and comment changes
- this is a follow-up to PR #43656
- tested on branch dev-4.4 successfully
* Change to writeRelativeFile in 2 samples too
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request for Issue #43620 and Issue #43622
Summary of Changes
Testing Instructions
tested was #43620 with branch dev-4.4 on macOS 14.5 Sonoma, Windows 11 Pro and Ubuntu 24.04 LTS Noble Numbat
AssertionError: Timed out retrying after 4000ms: Expected to find element:
#jform_language, but never found it.at Context.installJoomla (webpack://joomla/./node_modules/joomla-cypress/src/joomla.js:10:0)
tested was #43622 with branch dev-4.4 on macOS 14.5 Sonoma, Windows 11 Pro and Ubuntu 24.04 LTS Noble Numbat
AssertionError: Timed out retrying after 4000ms: Expected to find element:
#jform_language, but never found it.at Context.installJoomla (webpack://joomla/./node_modules/joomla-cypress/src/joomla.js:10:0)
tested with branches dev-4.4, dev-5.1, dev-5.2 and dev-6.0 on docker based installation
Actual result BEFORE applying this Pull Request
Expected result AFTER applying this Pull Request
Link to documentations
Please select:
Documentation link for docs.joomla.org:
No documentation changes for docs.joomla.org needed
Pull Request link for manual.joomla.org:
No documentation changes for manual.joomla.org needed
Upmerge