[cypress] Rename deleteFolder to clarify function #43663
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- rename deleteFolder > deleteRelativePath
- to respect the custom task also deletes files and it does it relative to cmsPath
- rename writeFile > writeRelativeFile
- to unify task naming and to clarify it write relative to cmsPath
- additinal:
- small comment enhancements
- using const name 'path' from require('path');
- no functionality is changed, only method name, variable name and comment changes
- this is a follow-up to PR joomla#43656
- tested on branch dev-4.4 successfully
|
Thanks! |
LadySolveig
added a commit
to LadySolveig/joomla-cms
that referenced
this pull request
Jun 20, 2024
LadySolveig
added a commit
to LadySolveig/joomla-cms
that referenced
this pull request
Jun 20, 2024
laoneo
added a commit
that referenced
this pull request
Jun 24, 2024
* [4.4] Move the Cypress Tests to ESM * drone signature * resolve conflicts with #43663 - part 2 * Fix path.join * Fix path.join - 2 * Fix import join from path * Remove the forgotten commented out orginial imports from plugin/index.js --------- Co-authored-by: Allon Moritz <allon.moritz@digital-peak.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of Changes
deleteFolder>deleteRelativePathcmsPathwriteFile>writeRelativeFilecmsPathpathfromrequire('path');Testing Instructions
tests/System/README.mdActual result BEFORE applying this Pull Request
./.
Expected result AFTER applying this Pull Request
The system tests are running successfully with the renamed user-defined tasks and the README has been updated.
Link to documentations
Please select:
Documentation link for docs.joomla.org:
No documentation changes for docs.joomla.org needed
Pull Request link for manual.joomla.org:
No documentation changes for manual.joomla.org needed