Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added Exception Message to Taks Notification Email #43666

Open
wants to merge 12 commits into
base: 5.1-dev
Choose a base branch
from
Open

Added Exception Message to Taks Notification Email #43666

Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
22beae0
[cypress] System Tests fixes #43620, fixes #43622 (#43656)
muhme Jun 17, 2024
ef5e25d
Added Exception Message to Taks Notification Email
brbrbr Jun 17, 2024
4e513a6
Merge branch 'joomla:4.4-dev' into tasknotification-with-exception
brbrbr Jun 17, 2024
cca46a3
Removed reference to Joomla! admin.
brbrbr Jun 18, 2024
7c28032
New Line
brbrbr Jun 18, 2024
2be688a
Hello
brbrbr Jun 18, 2024
7d828ba
Added trace string
brbrbr Jun 18, 2024
17305b1
Removed a merged file from pull request
brbrbr Jun 18, 2024
26a9ab8
Merge branch 'tasknotification-with-exception' of https://github.com/…
brbrbr Jun 18, 2024
4c5d290
php-cs-fixer
brbrbr Jun 18, 2024
4752ca9
Typoes
brbrbr Jun 18, 2024
03eef8e
phpcs fix
brbrbr Jun 18, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Typoes
  • Loading branch information
@brbrbr
brbrbr committed Jun 18, 2024
commit 4752ca9f2769d40692ee303f0404906e93e06116
2 changes: 1 addition & 1 deletion plugins/system/tasknotification/src/Extension/TaskNotification.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -242,7 +242,7 @@ private function getDataFromTask(Task $task): array
'EXEC_DATE_TIME' => $lockOrExecTime,
'TASK_OUTPUT' => $task->getContent()['output_body'] ?? '',
'TASK_EXCEPTION' => ($task->getContent()['exception']?->getMessage() ?? '')
."\n\n". // this might rersult in one or two empty strings with new Lines. Not too visible in email or html so not really worth the effort to add a lot of extra code to optimize this
."\n\n". // This might result in one or two empty strings with new Lines. Not too visible in email or HTML, so not really worth the effort to add a lot of extra code to optimize this.
Path::removeRoot($task->getContent()['exception']?->getTraceAsString() ?? '')
,
];
Expand Down