Added Exception Message to Taks Notification Email #43666
+5
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…#43656) - fixes issue joomla#43620 - if no 'rm' command is available on Windows - fixes issue joomla#43622 - if cmsPath is set - custom task 'deleteFolder' can also delete a file and ignores if the file does not exist -> exactly what we need - once PR is merged i will create the next PR to rename 'deleteFolder' as 'deleteRelativePath' and also 'writeFile' as 'writeRelativeFile' to better represent the functions
|
If the email now includes the message is there any point in telling someone to go to the joomla admin etc? |
Good point, Actually, in the current situation, there is also no point of telling someone to go to the admin. Since there is no information there. Should I include the debug trace in the email as well? That one is neither stored nor logged. Bram |
This information in lost after task completion
…brbrbr/joomla-cms into tasknotification-with-exception
richard67
reviewed
Jun 18, 2024
plugins/system/tasknotification/src/Extension/TaskNotification.php
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of Changes
The email sent by the system plugin task notification contains very little useful information. This adjustment adds the Exception message to the emails.
The emails point to the Joomla! backend for more information, however there is no info in the dashboard since the taskcontent is not stored and the logs are well hidden.
Testing Instructions
Enable email notifications for failure for any active task for example in sessiongc. Is enabled by default.
Throw an exception in that task, for example:
` private function sessionGC(ExecuteTaskEvent $event): int
{
...
`
execute the task
Actual result BEFORE applying this Pull Request
Email with little information
Expected result AFTER applying this Pull Request
Email with the exception message
Link to documentations
Please select:
Documentation link for docs.joomla.org:
No documentation changes for docs.joomla.org needed
Pull Request link for manual.joomla.org:
No documentation changes for manual.joomla.org needed