[4.4] ESM follow up changes #43703
Merged
[4.4] ESM follow up changes #43703
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With PR joomla#43676 '[4.4] Move the Cypress Tests to ESM' the Cypress config file is changed to `cypress.config.mjs`. There are places in source code tree with the old file names `*.js`, that are handled by: 1. In the script used to build Joomla distribution archive packages, in the ignore file list, the Cypress config file name has been changed to the new `.mjs`. 2. In the delete-file-that-should-not-exist list, `cypress.config.mjs`and `cypress.config.dist.mjs` have been added.
richard67
reviewed
Jun 25, 2024
See Conversation joomla#43703 (comment)
richard67
approved these changes
Jun 26, 2024
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of Changes
With PR #43676 '[4.4] Move the Cypress Tests to ESM' the Cypress config file is changed to
cypress.config.mjs. There are places in source code tree with the old file names*.js, that are handled by:cypress.config.dist.mjs.2. In the delete-file-that-should-not-exist list,-> see conversationcypress.config.mjsandcypress.config.dist.mjshave been added.Testing Instructions
cypress.config.dist.mjsis not packedRundeleteUnexistingFilesfrom ??? and check oldcypress.config.jsandcypress.config.dist.jsare deleted; new filescypress.config.mjsandcypress.config.dist.mjsare deleted too.Actual result BEFORE applying this Pull Request
cypress.config.dist.mjsis not ignored in building Joomla distribution archive packagecypress.config.mjsandcypress.config.dist.mjsare not deleted on deleting files that should not existExpected result AFTER applying this Pull Request
cypress.config.dist.mjsis ignored in building Joomla distribution archive packagecypress.config.mjsandcypress.config.dist.mjs, as well ascypress.config.jsandcypress.config.dist.jsare deleted on deleting files that should not existLink to documentations
Please select:
Documentation link for docs.joomla.org:
No documentation changes for docs.joomla.org needed
Pull Request link for manual.joomla.org:
No documentation changes for manual.joomla.org needed