[4.4] Move the Cypress Tests to ESM #43676
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks as I really like the change. I'm merging this as last one when the other system test pr's are merged, so we have no conflicts in them. |
laoneo
reviewed
Jun 24, 2024
|
Thanks! |
alikon
added a commit
to alikon/joomla-cms
that referenced
this pull request
Jun 25, 2024
laoneo
pushed a commit
that referenced
this pull request
Jun 25, 2024
muhme
added a commit
to muhme/joomla-cms
that referenced
this pull request
Jun 25, 2024
After PR joomla#43676 '[4.4] Move the Cypress Tests to ESM' the cypress config file is renamed to `.mjs`. This PR is for updating README and architecture pictures.
muhme
added a commit
to muhme/joomla-cms
that referenced
this pull request
Jun 25, 2024
With PR joomla#43676 '[4.4] Move the Cypress Tests to ESM' the Cypress config file is changed to `cypress.config.mjs`. There are places in source code tree with the old file names `*.js`, that are handled by: 1. In the script used to build Joomla distribution archive packages, in the ignore file list, the Cypress config file name has been changed to the new `.mjs`. 2. In the delete-file-that-should-not-exist list, `cypress.config.mjs`and `cypress.config.dist.mjs` have been added.
laoneo
pushed a commit
that referenced
this pull request
Jun 26, 2024
* [cypress] Update doc for cypress.config.[dist].mjs After PR #43676 '[4.4] Move the Cypress Tests to ESM' the cypress config file is renamed to `.mjs`. This PR is for updating README and architecture pictures. * Update Code sample defaultCommandTimeout Update with Cypress defineConfig() syntax for new ESM * Explicit name cypress.config.mjs and use npm run 1. Error messages still mention `cypress.config.js`, e.g. on EADDRINUSE, even there is only `cypress.config.mjs` exisiting: ``` Your configFile threw an error from: cypress.config.js ``` This is avoided for `npm run cypress` by explicitly specifying the name `cypress.config.mjs`. 2. As this does not work for `npx cypress`, all given commands are changed to use `npm run cypress`.
laoneo
pushed a commit
that referenced
this pull request
Jun 26, 2024
* [4.4] Update file lists for cypress.config*.mjs With PR #43676 '[4.4] Move the Cypress Tests to ESM' the Cypress config file is changed to `cypress.config.mjs`. There are places in source code tree with the old file names `*.js`, that are handled by: 1. In the script used to build Joomla distribution archive packages, in the ignore file list, the Cypress config file name has been changed to the new `.mjs`. 2. In the delete-file-that-should-not-exist list, `cypress.config.mjs`and `cypress.config.dist.mjs` have been added. * Fix typo * Reverted script.php add-ons See Conversation #43703 (comment)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request for Issue # .
Summary of Changes
Thank you @dgrammatiko - This is only the continuition of the PR #42939 backported to 4.4 so we can upmerge in 5.1 and 5.2
Testing Instructions
Review and passing automated tests
Actual result BEFORE applying this Pull Request
Tests pass
Expected result AFTER applying this Pull Request
Tests pass
Link to documentations
Please select:
Documentation link for docs.joomla.org:
No documentation changes for docs.joomla.org needed
Pull Request link for manual.joomla.org:
No documentation changes for manual.joomla.org needed