-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[4.4] Fix newsfeed category html view #43879
Conversation
Merge branch '4.4-dev'
Consider file permissions when writing configuration in system tests …
merge joomla/joomla-cms branch 4.4-dev
merge base 4.4-dev
[4.x] Translation Update (joomla#43518)
merge head-repository joomla/joomla-cms
merge head repository joomla/joomla-cms
merge from head repository
I have tested this item ✅ successfully on fe9bd06 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43879. |
I have tested this item ✅ successfully on fe9bd06 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43879. |
I have tested this item ✅ successfully on fe9bd06 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43879. |
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43879. |
Thanks! |
Summary of Changes
Fix newsfeed category html view as down-merge from 5.1-dev. This is a sub-part from #43722 to use joomla-cypress 1.1.1 in 4.4-dev too.
Testing Instructions
The warning is displayed in A) the frontenend view and B) the System Test (with a speaking
checkForPhpNoticesOrWarnings
). Verify the warning before patching. After patching, check that there are no more warnings.Actual result BEFORE applying this Pull Request
A) Manual Test
Requesting URL
/index.php?option=com_newsfeeds&view=category&id=5
in fresh 4.4-dev shows the PHP Warning message (id comes from Components | News Feeds | Categories | Uncategorised):B) System Test
As preparation install speaking
checkForPhpNoticesOrWarnings
in overwriting lines 74 ... 89 innode_modules/joomla-cypress/src/support.js
with the following lines:Run the test specifications:
Fails with:
💡 With overwritten speaking
checkForPhpNoticesOrWarnings
, if you run the entire system tests, there are four failures before this PR and only three after. The remaining three errors are fixed by #43880 and #43881.Expected result AFTER applying this Pull Request
No warnings in A) frontend view or B) System Test.
Link to documentations
Please select:
Documentation link for docs.joomla.org:
No documentation changes for docs.joomla.org needed
Pull Request link for manual.joomla.org:
No documentation changes for manual.joomla.org needed
Up-Merging
@LadySolveig @bembelimen there is no up-merge required as it is only a down-merge from 5.1-dev