merge joomla/joomla-cms branch 4.4-dev #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* nested set table * nested set table * cs * cs * cs * cs * mainmenu * before * drone * feedback * feedback * chain * async * cs * cs * return * easier2read Co-authored-by: Allon Moritz <allon.moritz@digital-peak.com> --------- Co-authored-by: Allon Moritz <allon.moritz@digital-peak.com>
* com_languages * typo * silly lint * Update tests/System/integration/administrator/components/com_languages/Installed.cy.js Co-authored-by: Allon Moritz <allon.moritz@digital-peak.com> * Update tests/System/integration/administrator/components/com_languages/Installed.cy.js Co-authored-by: Allon Moritz <allon.moritz@digital-peak.com> * Update tests/System/integration/administrator/components/com_languages/Installed.cy.js Co-authored-by: Allon Moritz <allon.moritz@digital-peak.com> * Update tests/System/integration/administrator/components/com_languages/Installed.cy.js Co-authored-by: Allon Moritz <allon.moritz@digital-peak.com> --------- Co-authored-by: Allon Moritz <allon.moritz@digital-peak.com>
* whosonline * cs
* System Tests README extended - Extended with software architecture pictures and new folder tests/System/images for used architecture diagrams, see README.md there - Described software architecture as overview and second time in detail - Detailed and updated the existing documentation - Added hints for testing and development - Added troubleshooting * added images folder to exclude * Update tests/System/README.md - Better English Co-authored-by: Brian Teeman <brian@teeman.net> * Update tests/System/README.md - Better English Co-authored-by: Brian Teeman <brian@teeman.net> * Update tests/System/README.md - Better English Co-authored-by: Brian Teeman <brian@teeman.net> * Update tests/System/README.md - Better English Co-authored-by: Brian Teeman <brian@teeman.net> * Update tests/System/README.md - Better English Co-authored-by: Brian Teeman <brian@teeman.net> * Update tests/System/images/README.md – British English spelling Co-authored-by: Brian Teeman <brian@teeman.net> * corrected exclude list to tests/System/images * one paragraph reworded after the suggestion --------- Co-authored-by: Brian Teeman <brian@teeman.net>
* Small spelling correction in dock blocks * also fixed double * also fixed double to-s * also fixed double for ---------
* fix missing areialabel in pagenavigation * Better aria-label * loadlanguage * Update plugins/content/pagenavigation/tmpl/default.php Co-authored-by: Brian Teeman <brian@teeman.net> ---------
* remove unused inline event handler * remove other instances of onload handler * remove obsolete media attributes ---------
A very simple PR just to remove an unnecessary newline character in a comment.
- fixes issue #43620 - if no 'rm' command is available on Windows - fixes issue #43622 - if cmsPath is set - custom task 'deleteFolder' can also delete a file and ignores if the file does not exist -> exactly what we need - once PR is merged i will create the next PR to rename 'deleteFolder' as 'deleteRelativePath' and also 'writeFile' as 'writeRelativeFile' to better represent the functions
* cy-checkin * cs * less * cs * Update tests/System/integration/administrator/components/com_checkin/Default.cy.js Co-authored-by: Brian Teeman <brian@teeman.net> * Update tests/System/integration/administrator/components/com_checkin/Default.cy.js Co-authored-by: Brian Teeman <brian@teeman.net> --------- Co-authored-by: Brian Teeman <brian@teeman.net>
* cy.cache * Update tests/System/integration/administrator/components/com_cache/Default.cy.js Co-authored-by: Heiko Lübbe <github@heikol.de> * 4.4-only --------- Co-authored-by: Heiko Lübbe <github@heikol.de> Co-authored-by: Allon Moritz <allon.moritz@digital-peak.com>
* [cypress] Rename deleteFolder to clarify function
- rename deleteFolder > deleteRelativePath
- to respect the custom task also deletes files and it does it relative to cmsPath
- rename writeFile > writeRelativeFile
- to unify task naming and to clarify it write relative to cmsPath
- additinal:
- small comment enhancements
- using const name 'path' from require('path');
- no functionality is changed, only method name, variable name and comment changes
- this is a follow-up to PR #43656
- tested on branch dev-4.4 successfully
* Change to writeRelativeFile in 2 samples too
* cy.mails * Update tests/System/integration/administrator/components/com_mails/Templates.cy.js Co-authored-by: Brian Teeman <brian@teeman.net> --------- Co-authored-by: Brian Teeman <brian@teeman.net>
* Fail in case of SMTP problems with a clear message
If the array `mail[]` is empty width length 0, the line
`cy.wrap(mails).should('have.lengthOf', 1);`
does not cause the test to stop in this case as the Cypress
assertion inside the `.then()` has an asynchronous nature.
The effect is that the test run continues and the following access
to the mail fails with with a somehow incomprehensible message e.g.
`TypeError: Cannot read properties of undefined (reading 'body')`
Replaced it with an `expect` statement, which immediately triggers an error,
and added an individual message that the SNMP configuration may need to be checked.
Added two more places.
* Remove custom failure msg from mail cnt assertion
* Update tests/System/integration/administrator/components/com_config/Application.cy.js
---------
Co-authored-by: Allon Moritz <allon.moritz@digital-peak.com>
* Do real login test * more tests * cs * Clear the session * cs
* cy-actionlogs * cs * cs * test * test * noresult * cs * simplify * cs * Update tests/System/integration/administrator/components/com_actionlogs/Actionlogs.cy.js Co-authored-by: Allon Moritz <allon.moritz@digital-peak.com> * Update tests/System/integration/administrator/components/com_actionlogs/Actionlogs.cy.js Co-authored-by: Allon Moritz <allon.moritz@digital-peak.com> * desc * enabled-as-default --------- Co-authored-by: Allon Moritz <allon.moritz@digital-peak.com>
* [4.4] Move the Cypress Tests to ESM * drone signature * resolve conflicts with #43663 - part 2 * Fix path.join * Fix path.join - 2 * Fix import join from path * Remove the forgotten commented out orginial imports from plugin/index.js --------- Co-authored-by: Allon Moritz <allon.moritz@digital-peak.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request for Issue # .
Summary of Changes
Testing Instructions
Actual result BEFORE applying this Pull Request
Expected result AFTER applying this Pull Request
Link to documentations
Please select:
Documentation link for docs.joomla.org:
No documentation changes for docs.joomla.org needed
Pull Request link for manual.joomla.org:
No documentation changes for manual.joomla.org needed