Skip to content
This repository has been archived by the owner on May 4, 2018. It is now read-only.

osx: erroneous polyfill for kFSEventStreamCreateFlagNoDefer for OS X < 10.7 #1000

Closed
ci42 opened this issue Nov 21, 2013 · 0 comments
Closed

Comments

@ci42
Copy link
Contributor

ci42 commented Nov 21, 2013

Commit 0f5c28b introduced a kFSEventStreamCreateFlagNoDefer polyfill in src/unix/internal.h for OS X < 10.7. But kFSEventStreamCreateFlagNoDefer is already defined in

/System/Library/Frameworks/CoreServices.framework/Frameworks/CarbonCore.framework/Headers/FSEvents.h

since 10.5, which causes the following build failure on 10.6 (probably on 10.5 too):

/src/unix/internal.h:246:18: error: redefinition of 'kFSEventStreamCreateFlagNoDefer' as different kind of symbol
static const int kFSEventStreamCreateFlagNoDefer = 0x00000002;
                 ^
/System/Library/Frameworks/CoreServices.framework/Frameworks/CarbonCore.framework/Headers/FSEvents.h:237:3: note: previous definition is here
  kFSEventStreamCreateFlagNoDefer = 0x00000002,
  ^
1 error generated.
ci42 added a commit to ci42/libuv that referenced this issue Nov 21, 2013
The kFSEventStreamCreateFlagNoDefer flag is already
defined in CarbonCore/FSEvents.h since OS X 10.5.

Fixes joyent#1000.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant