This repository has been archived by the owner on May 4, 2018. It is now read-only.
fsevents: remove kFSEventStreamCreateFlagNoDefer polyfill #1001
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for contributing this pull request! Here are a few pointers to make sure your submission will be considered for inclusion. Commit ci42/libuv@2ddbc91 has the following error(s):
The following commiters were not found in the CLA:
You can fix all these things without opening another issue. Please see CONTRIBUTING.md for more information |
|
LGTM, but please fix nits mentioned by @Nodejs-Jenkins . |
The kFSEventStreamCreateFlagNoDefer flag is already defined in CarbonCore/FSEvents.h since OS X 10.5. Fixes joyent#1000.
|
@indutny I fixed the commit message. Is the CLA really necessary for a one line change? |
|
@ci-innoq I'm afraid - yes. |
|
@indutny CLA: done. |
|
Thank you! Landed in c438e73 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
kFSEventStreamCreateFlagNoDefer already exists in /System/Library/Frameworks/CoreServices.framework/Frameworks/CarbonCore.framework/Headers/FSEvents.h since OS X 10.5
see #1000