storybook.js.org

[shilman]

• There is reasonable content on the page (see: No Content)
• I have read and accepted the Terms and Conditions

Move storybook to netlify to simplify our docs publishing flow

[indus]

This should be approved by @mnmtanish. He has requested the domain. Otherwise it is hard for me to know this is legit.
If he is no longer working for the project, another option would be to remove the CNAME in the repo. But that would make your site unreachable until I continue to process the request. I just want to amke sure nobody kidnaps the subdomain of someone else ;-)

[shilman]

@indus Awesome, thanks so much for your help. @mnmtanish is a friend and I've asked him to approve it via FB/slack/etc, so hopefully he'll comment here soon.

If not, we can do the CNAME option or take another approach to proving project ownership (e.g. I'm a github admin for the package, have published all the releases on NPM for the past year, etc. etc.).

[thani-sh]

Hi @indus, @shilman is maintaining this project now. Can you go ahead and make the change. Thanks.

[indus]

I've made the changes and will take @shilman as authorized for further changes.
I now get a "not found" message. You propably have to configure netlify correct.

I'm not sure you have noticed, but there is a second subdomain "storybooks" that still directs to the Github-Page

[shilman]

Ugh, sorry about this. Working with Netlify to get this resolved on that side!

[indus]

Looks good to me now. Welcome back https://storybook.js.org

[shilman]

Hi @indus! Thanks so much for your help and I have a small follow-up request here. Currently storybook.js.org is going through both the netlify CDN and also the cloudflare CDN. I'm told by Netlify that this can cause caching issues and other potential issues. Would it be possible to bypass Cloudflare for this domain? It's a single setting in Cloudflare:

It's possible that the site will be off SSL temporarily, but the team and I are OK with that. Documenting here storybookjs/storybook#4126 (comment).

Many thanks!

[indus]

Just make a pull request andadd a comment //noCF in the end of your line. FYI: https://github.com/js-org/js.org/blob/master/cnames_active.js#L18-L23 (it says "make Cloudflare forward all requests directly to GitHub" but in your case it is of course netlify)