Remove gh-pages deploy in favor of netlify #4128
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Keep the deploy step as a placeholder
Codecov Report
@@ Coverage Diff @@
## master #4128 +/- ##
=========================================
Coverage ? 40.59%
=========================================
Files ? 483
Lines ? 5747
Branches ? 770
=========================================
Hits ? 2333
Misses ? 3042
Partials ? 372Continue to review full report at Codecov.
|
pksunkara
reviewed
Sep 6, 2018
.circleci/config.yml
Outdated
| git config --global user.email "gh-pages@localhost" | ||
| git config --global user.name "npm gh-pages" | ||
| yarn deploy:ci | ||
| echo "Nothing to deploy" |
ndelangen
approved these changes
Sep 6, 2018
|
@shilman Before merging this PR, could you please address this? #4126 (comment). We need to figure out what process we are going to follow. |
pksunkara
approved these changes
Sep 7, 2018
|
I actually realized that the current deploy job is broken anyway because of circleci tag filter rule. So, I am merging this. |
Hypnosphi
added
the
patch:yes
shilman
added
the
patch:done
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: #4126
What I did
Now the gh-pages branch will go out of date (and we should probably remove it once we are fully onto netlify), and storybook.js.org points to the netlify instance rather than to storybooks.github.io/storybook (See js-org/js.org#2304)
How to test
Not really testable until we merge this into a tag
vX.Y.Zcommit. But I've been messing around with this for an hour or so, and am confident it's safe.