Feat: autohttps readinessProbe for quicker validated startup and shutdown #1633
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When the autohttps deployment is updating, it keeps existing connections open for a while before it shuts down, but it closes itself for new connections. After it has closed itself for new connections, it is still considered ready by the service that delegates traffic, so that makes the pod continue to receive traffic that will crash. With this change, it will stop receiving traffic, which is preferred as it isn't actually doing its job to receive it as it should any more at this stage.
|
Note that CircleCI fails due to warnings turned into errors - and the warnings showed up in Sphinx 3. Something to be fixed by another PR. |
|
I've tested this locally and it works great, reducing the disruptions of service during upgrades from ~30 seconds of flakyness down to just a few seconds. |
consideRatio
changed the title
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the autohttps deployment is updating, it keeps existing connections
open for a while before it shuts down, but it closes itself for new
connections.
After it has closed itself for new connections, it is still considered
ready by the service that delegates traffic, so that makes the pod
continue to receive traffic that will crash.
With this change, it will stop receiving traffic, which is preferred as
it isn't actually doing its job to receive it as it should any more at
this stage.