Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: autohttps readinessProbe for quicker validated startup and shutdown #1633

Merged

Commits on Apr 19, 2020

  1. Feat: autohttps readinessProbe for quicker shutdowns

    When the autohttps deployment is updating, it keeps existing connections 
    open for a while before it shuts down, but it closes itself for new 
    connections.
    
    After it has closed itself for new connections, it is still considered 
    ready by the service that delegates traffic, so that makes the pod 
    continue to receive traffic that will crash.
    
    With this change, it will stop receiving traffic, which is preferred as 
    it isn't actually doing its job to receive it as it should any more at 
    this stage.
    consideRatio committed Apr 19, 2020
    Configuration menu
    Copy the full SHA
    46e39bb View commit details
    Browse the repository at this point in the history