Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix newline typo in improve_code #364

Merged
merged 1 commit into from
Aug 29, 2023

Conversation

michaelchia
Copy link
Collaborator

No description provided.

@welcome
Copy link

welcome bot commented Aug 28, 2023

Thanks for submitting your first pull request! You are awesome! 🤗

If you haven't done so already, check out Jupyter's Code of Conduct. Also, please make sure you followed the pull request template, as this will help us review your contribution more quickly.
welcome
You can meet the other Jovyans by joining our Discourse forum. There is also a intro thread there where you can stop by and say Hi! 👋

Welcome to the Jupyter community! 🎉

@JasonWeill JasonWeill linked an issue Aug 28, 2023 that may be closed by this pull request
@JasonWeill JasonWeill added bug Something isn't working @jupyter-ai/chatui labels Aug 28, 2023
Copy link
Collaborator

@3coins 3coins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@michaelchia
Thanks for fixing this. Looks great!

@3coins 3coins merged commit 04324c1 into jupyterlab:main Aug 29, 2023
7 checks passed
@welcome
Copy link

welcome bot commented Aug 29, 2023

Congrats on your first merged pull request in this project! 🎉
congrats
Thank you for contributing, we are very proud of you! ❤️

dlqqq pushed a commit to dlqqq/jupyter-ai that referenced this pull request Sep 5, 2023
dlqqq added a commit that referenced this pull request Sep 5, 2023
* Update README, docs (#347)

* Copy edits for brevity, adds large screenshot

* Adds screenshot, adds principles to contributor docs

* Uses screenshot class for home page image

* Fix reference to screenshot

* Copy edits

* Update index.md

Styles magic command

* Copy edits based on @dlqqq's feedback

* fix newline typo in improve_code (#364)

* Remove frontend js unit tests as not planned (#371)

* Added alias for bedrock titan model (#368)

* Added alias for bedrock titan model

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

---------

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>

* relax pinning on importlib_metadata, typing_extensions (#363)

== pinning is almost always to be avoided in packages,
and tight pinning on backports like importlib_metadata is extremely unlikely to be desirable

* Loads vector store index lazily (#374)

* Upgrades LangChain to 0.0.277

* Pinned Pydantic version, updated pydantic references

* add .yarn to .gitignore in 1.x for local dev

---------

Co-authored-by: michaelchia <michael_chia7@msn.com>
Co-authored-by: Andrii Ieroshenko <aieroshe@amazon.com>
Co-authored-by: Piyush Jain <piyushjain@duck.com>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Min RK <benjaminrk@gmail.com>
dbelgrod pushed a commit to dbelgrod/jupyter-ai that referenced this pull request Jun 10, 2024
@michaelchia michaelchia deleted the fix-generate-typo branch September 4, 2024 05:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working @jupyter-ai/chatui
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Typo in chat_handlers/generate.py
3 participants