Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Loads vector store index lazily #374

Merged
merged 1 commit into from
Sep 1, 2023
Merged

Conversation

3coins
Copy link
Collaborator

@3coins 3coins commented Aug 31, 2023

Fixes #357

@3coins
Copy link
Collaborator Author

3coins commented Aug 31, 2023

@michaelchia
Would be great if you can review this and confirm this fixes the issue on your end.

@3coins 3coins added the enhancement New feature or request label Aug 31, 2023
@3coins 3coins added this to the 2.2.0 Release milestone Aug 31, 2023
@3coins 3coins self-assigned this Aug 31, 2023
@3coins 3coins marked this pull request as ready for review August 31, 2023 01:33
@michaelchia
Copy link
Collaborator

@3coins Due to some logistics it is a bit difficult for me to run the changes and test it explicitly. But based on the code your solution looks good. Thanks for the great work.

@3coins 3coins merged commit 1556a02 into jupyterlab:main Sep 1, 2023
5 of 6 checks passed
dlqqq pushed a commit to dlqqq/jupyter-ai that referenced this pull request Sep 5, 2023
dlqqq added a commit that referenced this pull request Sep 5, 2023
* Update README, docs (#347)

* Copy edits for brevity, adds large screenshot

* Adds screenshot, adds principles to contributor docs

* Uses screenshot class for home page image

* Fix reference to screenshot

* Copy edits

* Update index.md

Styles magic command

* Copy edits based on @dlqqq's feedback

* fix newline typo in improve_code (#364)

* Remove frontend js unit tests as not planned (#371)

* Added alias for bedrock titan model (#368)

* Added alias for bedrock titan model

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

---------

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>

* relax pinning on importlib_metadata, typing_extensions (#363)

== pinning is almost always to be avoided in packages,
and tight pinning on backports like importlib_metadata is extremely unlikely to be desirable

* Loads vector store index lazily (#374)

* Upgrades LangChain to 0.0.277

* Pinned Pydantic version, updated pydantic references

* add .yarn to .gitignore in 1.x for local dev

---------

Co-authored-by: michaelchia <michael_chia7@msn.com>
Co-authored-by: Andrii Ieroshenko <aieroshe@amazon.com>
Co-authored-by: Piyush Jain <piyushjain@duck.com>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Min RK <benjaminrk@gmail.com>
dbelgrod pushed a commit to dbelgrod/jupyter-ai that referenced this pull request Jun 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Do not call any LLMs on start (LearnChatHandler).
3 participants