Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CI tests on Alpine 3.17 #6744

Merged
merged 1 commit into from
Jan 14, 2023
Merged

Conversation

brandond
Copy link
Member

@brandond brandond commented Jan 13, 2023

Proposed Changes

  • General cleanup of test-helpers functions to address CI failures (the shell script needed some love)
  • Install awscli in test image (not sure when this disappeared, but we weren't getting logs for failed tests)
  • Log containerd output to file even when running with --debug (we always run tests with --debug; this was making it harder to figure out what's failing when containerd doesn't start up right)

Types of Changes

CI bugfix

Verification

check CI test step output

Testing

Linked Issues

User-Facing Change

NONE

Further Comments

@brandond brandond requested a review from a team as a code owner January 13, 2023 18:34
@brandond brandond force-pushed the fix-test-helper-syntax branch 2 times, most recently from 90bc990 to 6595dc4 Compare January 13, 2023 20:01
* General cleanup of test-helpers functions to address CI failures
* Install awscli in test image
* Log containerd output to file even when running with --debug

Signed-off-by: Brad Davidson <brad.davidson@rancher.com>
@brandond brandond changed the title Fix test-helpers inc-count syntax Fix CI tests on Alpine 3.17 Jan 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants