Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Golang and Alpine image bumps #174

Merged
merged 2 commits into from
Apr 10, 2023
Merged

Golang and Alpine image bumps #174

merged 2 commits into from
Apr 10, 2023

Conversation

macedogm
Copy link
Member

@macedogm macedogm commented Apr 8, 2023

This PR does:

  1. Bump Golang and Alpine image versions to golang:1.20-alpine3.17 following PR Bump golang from 1.19-alpine3.16 to 1.20-alpine3.16 #164.
  2. Fixes a CI script failure (see failed pipeline) due to an update to Busybox's version. Part of the fix comes from Fix CI tests on Alpine 3.17 k3s#6744.
    1. This fix requires to add the package findutils to Dockerfile.test.dapper in order for find to support printf).
      1. Re-ordered alphabetically the packages installed by apk.
    2. Also re-ordered the parameters -mindepth 2 -maxdepth 2 -type d to make them work as expected and avoid failure:
find: warning: you have specified the global option -mindepth after the argument -type, but global options are not positional, i.e., -mindepth affects tests specified before it as well as those specified after it.  Please specify global options before other arguments.
find: warning: you have specified the global option -maxdepth after the argument -type, but global options are not positional, i.e., -maxdepth affects tests specified before it as well as those specified after it.  Please specify global options before other arguments.

Signed-off-by: Guilherme Macedo <guilherme.macedo@suse.com>
Signed-off-by: Guilherme Macedo <guilherme.macedo@suse.com>
@macedogm macedogm marked this pull request as ready for review April 10, 2023 13:54
@macedogm
Copy link
Member Author

@brandond CC

@brandond brandond merged commit b3ba9a6 into k3s-io:master Apr 10, 2023
@macedogm macedogm deleted the golang-alpine-image-bump branch April 10, 2023 18:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants