Handle minPxPerSec differently to allow for zooming #132
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…to handle updated minPxPerSec properly
Conflicts: build/wavesurfer-js-map.json build/wavesurfer.amd.js build/wavesurfer.min.js
Closed
|
Hi Mark, Thank you, I'll have a look tonight! |
katspaugh
added a commit
that referenced
this pull request
Mar 12, 2014
Handle minPxPerSec differently to allow for zooming
|
OK! |
|
Hi there, I'm currently trying to implement zoom-in / out method but facing problems :
Can you please provide an exemple that allow zoom-in and timeline update ? Thanks a lot ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the wavesurfer prototype to assign this.minPxPerSec before using it. This allows you to modify minPxPerSec externally and then drawBuffer, effectively adding a 'zoom' capability. It also adds a 'redraw' event that is triggered when drawBuffer() is called, allowing plugins (timeline, for example) to listen for this event and redraw accordingly.