Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds event bubbling for the 'mouseup' event so that external objects (including plugins) can listen for the 'mouseup' event that is triggered by wavesurfer. NOTE: This PR includes #132 and should only be merged if that PR is going to be merged.
@katspaugh - I noticed that when you refactored the drag events, you used document.addEventListener when registering the mouseup callback. What was your motivation for this? In order to properly bubble up a wavesurfer-only mouseup event, I had to add an additional listener for mouseup on the wavesurfer wrapper itself. I imagine there was some consideration that went into the decision to listen for that even on the document, but I couldn't deduce it from the code. Hence the additional listener, which shouldn't have any performance or other impact.
The main benefit of having this event (for our purposes, at least) is to listen for when a user has finished selecting a new region of the waveform.
Cheers,
Mark