regions plugin: move classes to separate files #1934
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… HTML5 audio tag and use it with WebAudio features.
- Put the possibility of handle audio tag with API Web Audio directly in the MediaElement backend, setting a new wavesurfer boolean parameter, 'mediaElementWebAudio', to true.
- fixed version number and switch-case
- updated changelog and added examples.
…for Region class, and moved both to plugin/regions dir - added findInDirectory function in the plugin build file, so the plugins entries can be found also if in deeper directories, recursively
thijstriemstra
suggested changes
May 4, 2020
added 2 commits
May 9, 2020 15:25
# Conflicts: # CHANGES.md # src/plugin/regions/region.js
- updated the way of building plugins, in particular using parent directory name for the plugin when its name is index.js - updated versioning and comments
marizuccara
commented
May 10, 2020
thijstriemstra
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
regions.jsfile was splitted in two files, one containing theRegionsPluginclass, another theRegionclass.This approach is useful because separating two conceptually different objects allows to treat them as different modules. In this way creating a Custom Plugin that extends the
RegionsPluginis simpler, and allows you to decide whether to leaveRegionclass unchanged, or extends it too.Breaking changes in the internal API:
regions.jsinindex.jsandregion.jsand moved both files insrc/plugin/regions/directory.Related Issues and other PRs:
PR #1928