Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

minimap plugin: added ability to use a customized regions plugin #1943

Merged
merged 39 commits into from
May 12, 2020
Merged

minimap plugin: added ability to use a customized regions plugin #1943

merged 39 commits into from
May 12, 2020

Conversation

marizuccara
Copy link
Contributor

Short description of changes:

To support customized regions plugin, it was added new parameter into minimap plugin, regionsPluginName, which could be setted to your custom region plugin name.

Breaking in the external API:

New parameter regionsPluginName for minimap plugin.

  • Its default value is 'regions'
  • If you setted showRegions to true and you're using a customized regions plugin calling it with a custom name, set its name to regionsPluginName parameter

Breaking changes in the internal API:

  • Added regionsPluginName in minimap parameters
  • Added new variable this.regionsPlugin, so it can be accessed from outside

Related Issues and other PRs:

PR #1934 #1928

marizuccara and others added 30 commits October 7, 2019 13:00
@marizuccara
Added WebAudioMedia backend which uses MediaElementSourceNode to load…
d10a612 
… HTML5 audio tag and use it with WebAudio features.
@marizuccara
- Removed WebAudioMedia backend
47de93f 
- Put the possibility of handle audio tag with API Web Audio directly in the MediaElement backend, setting a new wavesurfer boolean parameter, 'mediaElementWebAudio', to true.
@marizuccara
restore old new lines
a5538d4
@marizuccara
added comments to methods and properties
b5e8840
@marizuccara
Restored WebAudioMedia backend, added version
714e7ba
@marizuccara
added karma tests to WebAudioMedia backend
51a6ee6
@marizuccara
- added description to WebAudioMedia backend
d9d0f43 
- fixed version number and switch-case
@marizuccara
- fixed documentation
dc13b4a
@marizuccara
- added shared tests for MediaElement and WebAudioMedia backend.
731975b 
- updated changelog and added examples.
@thijstriemstra
Merge branch 'master' into master
2aa2d61
@thijstriemstra
Merge branch 'master' into master
52b3c23
@marizuccara
renamed WebAudio backend to MediaElementWebAudio
ea050c8
@marizuccara
Merge branch 'master' of https://github.com/marizuccara/wavesurfer.js
a2bd3c0
@marizuccara
fixed names
0d9189a
@marizuccara
added HTML5 load error tests to shared tests
0985ac0
@marizuccara
added example to MediaElementWebAudio backend
b6a91b2
@marizuccara
refactor names and add comments
b0dd6a0
@thijstriemstra
Merge branch 'master' into master
be04b43
@marizuccara
update new backend example
c70d36a
@marizuccara
Merge branch 'master' of https://github.com/marizuccara/wavesurfer.js
4172a53
example plugin inheritance
4cf06ea
- Added example of how create a plugin that extends an existing one
dcc8e5e
Added more descriptions
fc79f4f
fixed description
957906c
fixed CursorPlugin with CursorCustomPlugin in description
bbb61b2
Merge remote-tracking branch 'upstream/master'
0231950
destroy webaudio also for MediaElementWebAudio backend
ced3d9e
updated changelog
fa3068d
@thijstriemstra
rephrase
f19d62c
Merge remote-tracking branch 'upstream/master'
e8b24b5
marizuccara added 8 commits May 3, 2020 21:16
- splitted regions.js in two files, one for RegionsPlugin class, one …
ae1c37b 
…for Region class, and moved both to plugin/regions dir

- added findInDirectory function in the plugin build file, so the plugins entries can be found also if in deeper directories, recursively
added changelog and versioning
91ba451
Merge remote-tracking branch 'upstream/master'
d2f9afa 
# Conflicts:
#	CHANGES.md
#	src/plugin/regions/region.js
- renamed regions.js to index.js
9a18f22 
- updated the way of building plugins, in particular using parent directory name for the plugin when its name is index.js
- updated versioning and comments
fixed merge mismatch in regions/index.js when instantiate Region class
94a3071
Merge remote-tracking branch 'upstream/master'
9e7de97
Added the ability to use a customized regions plugin in the minimap…
fb60301 
… plugin through a new parameter `regionsPluginName`
updated changelog
a960e31
@coveralls
Copy link

coveralls commented May 11, 2020 •
edited
Loading

Coverage Status

Coverage remained the same at 80.62% when pulling 5b5cf6c on marizuccara:master into f1a9429 on katspaugh:master.

@marizuccara
Copy link
Contributor Author

Hi, I think that the plugin inheritance example should be updated, because we removed all private methods, so we can override them, instead of copying. What do you think? If yes open another pull request or reopen the old one?

@thijstriemstra thijstriemstra changed the title Added the ability to use a customized regions plugin in the minimap plugin minimap plugin: added ability to use a customized regions plugin May 12, 2020
@thijstriemstra
Copy link
Contributor

What do you think? If yes open another pull request or reopen the old one?

Sounds good; in a new one.

thijstriemstra
thijstriemstra approved these changes May 12, 2020
View reviewed changes
Copy link
Contributor

@thijstriemstra thijstriemstra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@thijstriemstra thijstriemstra merged commit a3712fb into katspaugh:master May 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thijstriemstra thijstriemstra thijstriemstra approved these changes

Assignees
No one assigned
Labels
plugins
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@marizuccara @coveralls @thijstriemstra