Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactored fallback logic to only patch status when the fallback is e… #5659

Merged
merged 19 commits into from
Aug 2, 2024
Merged

Refactored fallback logic to only patch status when the fallback is e… #5659

merged 19 commits into from
Aug 2, 2024

Conversation

bharathguvvala
Copy link
Contributor

@bharathguvvala bharathguvvala commented Apr 3, 2024 •
edited
Loading

…nabled

This change ensures that the update health status of the scaledObjects is only updated when the fallback configuration is enabled on the scaledobject. Further optimizations to avoid redundant updates when the status doesn't change can be done later. Tests will be added, if the change is ratified by the maintainers.

Checklist

Fixes #5624

@bharathguvvala
refactored fallback logic to only patch status when the fallback is e…
ac26a94 
…nabled

Signed-off-by: Bharath Guvvala <bharath.raghavendra@gmail.com>
@bharathguvvala bharathguvvala requested a review from a team as a code owner April 3, 2024 07:31
@bharathguvvala
Merge branch 'main' into upstreammain
d4b19ca
@bharathguvvala
removed newline
fe530f4 
Signed-off-by: Bharath Guvvala <bharath.raghavendra@gmail.com>
JorTurFer
JorTurFer reviewed Apr 7, 2024
View reviewed changes
Copy link
Member

@JorTurFer JorTurFer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Could you update the changelog linking the fixed issue? I think that improvements can be the better fit considering that this will improve the performance.
@zroubalik @dttung2905 PTAL if you have time :)

@JorTurFer
Copy link
Member

JorTurFer commented Apr 7, 2024 •
edited by github-actions bot
Loading

/run-e2e
Update: You can check the progress here

@JorTurFer
Copy link
Member

@bharathguvvala , could you check the failing CI checks? I think that unit tests probably need to be updated as they expect the call to patch

@zroubalik zroubalik self-requested a review April 10, 2024 17:02
@bharathguvvala
formatted imports
4db4daa 
Signed-off-by: Bharath Guvvala <bharath.raghavendra@gmail.com>
@bharathguvvala
WIP: verifying test failure fixes
69a10f3 
Signed-off-by: Bharath Guvvala <bharath.raghavendra@gmail.com>
@bharathguvvala
Merge branch 'main' into upstreammain
c1a674b
JorTurFer
JorTurFer reviewed Apr 11, 2024
View reviewed changes
pkg/fallback/fallback_test.go Outdated Show resolved Hide resolved
pkg/fallback/fallback_test.go Outdated Show resolved Hide resolved
pkg/scaling/scale_handler_test.go Outdated Show resolved Hide resolved
pkg/scaling/scale_handler_test.go Outdated Show resolved Hide resolved
pkg/scaling/scale_handler_test.go Outdated Show resolved Hide resolved
pkg/scaling/scale_handler_test.go Outdated Show resolved Hide resolved
pkg/scaling/scale_handler_test.go Outdated Show resolved Hide resolved
pkg/scaling/scale_handler_test.go Outdated Show resolved Hide resolved
pkg/scaling/scale_handler_test.go Outdated Show resolved Hide resolved
@bharathguvvala
WIP: verifying test failure fixes
10fb40f 
Signed-off-by: Bharath Guvvala <bharath.raghavendra@gmail.com>
@bharathguvvala
Merge branch 'main' into upstreammain
e2e6a83
@bharathguvvala
WIP: verifying test failure fixes
21ce3ca 
Signed-off-by: Bharath Guvvala <bharath.raghavendra@gmail.com>
@bharathguvvala
WIP: verifying test failure fixes
e5b4035 
Signed-off-by: Bharath Guvvala <bharath.raghavendra@gmail.com>
@bharathguvvala
WIP: verifying test failure fixes
e82fd9e 
Signed-off-by: Bharath Guvvala <bharath.raghavendra@gmail.com>
zroubalik
zroubalik reviewed Jun 7, 2024
View reviewed changes
Copy link
Member

@zroubalik zroubalik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bharathguvvala hi, what is the status of this PR please?

zroubalik
zroubalik reviewed Jun 7, 2024
View reviewed changes
pkg/fallback/fallback.go Outdated Show resolved Hide resolved
@bharathguvvala
Copy link
Contributor Author

@bharathguvvala hi, what is the status of this PR please?

@zroubalik Apologies about the delay. I'll close this within a week before Jun 14.

@bharathguvvala @zroubalik
Update pkg/fallback/fallback.go
c456801 
Co-authored-by: Zbynek Roubalik <zroubalik@gmail.com>
Signed-off-by: Bharath Raghavendra Reddy Guvvala <bharath.raghavendra@gmail.com>
@zroubalik
Copy link
Member

@bharathguvvala hi, what is the status of this PR please?

@zroubalik Apologies about the delay. I'll close this within a week before Jun 14.

no worries, thanks for the update!

zroubalik
zroubalik reviewed Jun 25, 2024
View reviewed changes
Copy link
Member

@zroubalik zroubalik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bharathguvvala there are still failures in static checks and unit tests

@bharathguvvala
Merge branch 'main' into upstreammain
50fc145
@bharathguvvala
fixed test failures
b500990 
Signed-off-by: Bharath Guvvala <bharath.raghavendra@gmail.com>
@bharathguvvala
fixed test failures
44b169b 
Signed-off-by: Bharath Guvvala <bharath.raghavendra@gmail.com>
@bharathguvvala
Copy link
Contributor Author

/run-e2e

@bharathguvvala
Copy link
Contributor Author

@zroubalik there are some queued check. How do I get them to execute?

@bboreham
Copy link

How does this relate to #5871 ?

@dttung2905
Copy link
Contributor

dttung2905 commented Jul 28, 2024 •
edited by github-actions bot
Loading

/run-e2e
Update: You can check the progress here

@bharathguvvala
Copy link
Contributor Author

/run-e2e

@bharathguvvala
Copy link
Contributor Author

@zroubalik can we please merge these changes since the E2E have passed?

@JorTurFer
Copy link
Member

JorTurFer commented Aug 1, 2024 •
edited by github-actions bot
Loading

/run-e2e
Update: You can check the progress here

@JorTurFer
Copy link
Member

The e2e failure isn't related with this changes

@JorTurFer
Copy link
Member

JorTurFer commented Aug 2, 2024 •
edited by github-actions bot
Loading

/run-e2e internal
Update: You can check the progress here

@JorTurFer JorTurFer enabled auto-merge (squash) August 2, 2024 10:12
@JorTurFer JorTurFer merged commit 0d7c3bf into kedacore:main Aug 2, 2024
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zroubalik zroubalik zroubalik approved these changes

@JorTurFer JorTurFer JorTurFer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Colocating metrics provider along with the operator causes HPA delays if not configured properly
5 participants
@bharathguvvala @JorTurFer @zroubalik @bboreham @dttung2905